A problem when upgrading using the silent switch.

HandBrake for Windows support
Forum rules
An Activity Log is required for support requests. Please read How-to get an activity log? for details on how and why this should be provided.
Post Reply
Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

A problem when upgrading using the silent switch.

Post by Omar » Sat Aug 26, 2017 6:01 pm

I have a problem for a while, the silent switch (/S) works fine with installation, but it doesn't work right when upgrading from a previous release to a new one!
Example: If I have already v1.0.5 installed and tried to update to v1.0.7 using "/S" with the installer it just removes HandBrake v1.0.5 and doesn't install v1.0.7 ! And it doesn't even remove v1.0.5 completely! there are many leftovers! and it never installs v1.0.7 !
I have test several versions but all are the same! So, is there another switch I should use with "/S" to upgrade successfully ?!

User avatar
s55
HandBrake Team
Posts: 9166
Joined: Sun Dec 24, 2006 1:05 pm

Re: A problem when upgrading using the silent switch.

Post by s55 » Sat Aug 26, 2017 6:59 pm

It's probably a bug in the installer. /S is the only relevant switch.

I'll look into it when I get some time.

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Sat Aug 26, 2017 7:53 pm

Thank you so much :) it's been like that for a long time BTW.
It would be great if it is fixed in the next release :)

User avatar
s55
HandBrake Team
Posts: 9166
Joined: Sun Dec 24, 2006 1:05 pm

Re: A problem when upgrading using the silent switch.

Post by s55 » Sat Aug 26, 2017 8:17 pm

Try a nightly build dated tomorrow or later.

https://github.com/HandBrake/HandBrake/ ... 77539cde00

It looks like it was an intermittent failure since the installer wouldn't wait for the uninstaller to complete. Given the uninstaller is so quick, chances are quite a few people never noticed it.

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Sun Aug 27, 2017 10:46 am

Yeah that's sounds like the problem! I tried the new nightly build but it doesn't replace the last stable release, can you provide me a URL for a previous nightly build so I can test with it?

Image

User avatar
s55
HandBrake Team
Posts: 9166
Joined: Sun Dec 24, 2006 1:05 pm

Re: A problem when upgrading using the silent switch.

Post by s55 » Sun Aug 27, 2017 10:50 am

Yeh, the nightly build can be installed along side the normal release. We don't archive nightlies so best bet is to grab tomorrows nightly.

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Sun Aug 27, 2017 1:25 pm

Ok then, thanks a lot and I hope to see the fix in the next stable build :)

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Tue Jun 05, 2018 7:34 pm

Sadly this is still happening with v1.1.0 ! It's only fixed on Windows 7, but on Win 8.1 & Win 10 the issue remains..

User avatar
s55
HandBrake Team
Posts: 9166
Joined: Sun Dec 24, 2006 1:05 pm

Re: A problem when upgrading using the silent switch.

Post by s55 » Tue Jun 05, 2018 7:48 pm

Funny, I noticed the other day another issue with the Execwait fix. Due to the way NSIS works, there may not actually be any way to cleanly fix this issue :(

Basically, when you run the uninstaller, it copies itself to a temp folder then executes a second process. So execwait returns before that 2nd uninstaller finishes. So you can be installing / uninstalling at the same time still.

Planning to move to WIX at some point when I get time but that's a bigger more time consuming project.

User avatar
s55
HandBrake Team
Posts: 9166
Joined: Sun Dec 24, 2006 1:05 pm

Re: A problem when upgrading using the silent switch.

Post by s55 » Tue Jun 05, 2018 8:04 pm

The workaround, is to uninstall silently, wait, then install silently as two separate calls.

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Tue Jun 05, 2018 8:29 pm

Ok no problem :) Thanks for the reply! and good luck with this :)

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Tue Jun 05, 2018 9:45 pm

BTW can I use a single switch for the v1.1.0 to do all this automatically?
(Uninstall older version, wait, install new version)

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Tue Jun 19, 2018 11:55 am

Also it always works fine on Windows 7 !! But the issue is only in Windows 8 & 10 !

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Mon Sep 10, 2018 11:21 am

It's sad to see this unfixed yet with the latest update! it causes problem in SCCM environment too TBH !
Can you at least remove the ability to remove the older version before upgrading?
When it asks : (HandBreak is already installed, Click "OK" to remove the previous version or "Cancel" to continue.)
Because if I canceled that it automatically overwrite the previous version with the new one without any problems! I couldn't test that silently but I think there won't be a problem since it won't run the uninstaller !
So is there a switch for canceling the removal of previous version that I can use with /S ?
Or is there a switch to "Uninstall older version, wait, then install new version" that I can use with /S ?
If no then I suggest you remove the ability to remove the older version before upgrading in the next release :)

User avatar
s55
HandBrake Team
Posts: 9166
Joined: Sun Dec 24, 2006 1:05 pm

Re: A problem when upgrading using the silent switch.

Post by s55 » Mon Sep 10, 2018 5:47 pm

The problem with not running the uninstaller is it'll leave behind uninstallers listed on windows that no longer exist.

The MSI installer has been slowly crawling up my todo list as it'll help in a lot of scenarios, + in theory, it should be easier to deploy through Software centre et all.

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Mon Sep 10, 2018 6:52 pm

Yes an MSI installer would be great! I hope it will be available with the next update :)

User avatar
s55
HandBrake Team
Posts: 9166
Joined: Sun Dec 24, 2006 1:05 pm

Re: A problem when upgrading using the silent switch.

Post by s55 » Mon Sep 10, 2018 7:30 pm

I'm not sure but It's getting enough attention that it's higher up on my list.

Fwiw, it might be worth taking the "portable" version (zip package). It might be easier to deploy?

Omar
Posts: 11
Joined: Sat Aug 26, 2017 4:14 pm

Re: A problem when upgrading using the silent switch.

Post by Omar » Mon Sep 10, 2018 8:23 pm

No I can't use the portable edition, but it's ok I will wait for the MSI :)

Post Reply