[PATCH]Add new options for Subtitles in WinGUI

Archive of historical development discussions
Discussions / Development has moved to GitHub
Forum rules
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.

*******************************
Post Reply
Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

[PATCH]Add new options for Subtitles in WinGUI

Post by Shatian »

I asked if this was possible and it was marked not planned, so I decided to give it a shot at writing it myself.

I added an extra option to tell the GUI to use my preferred language as both the subtitle and the audio track, I also added a check box to tell the GUI to used the Closed Caption track if it doesn't find a sub that matches the preferred language. I also fixed a few tool tips while I was making the changes.

I added these because I rip a lot of television series DVDs and wanted to be able to always pick the English sub and dub.

http://handbrake.fr/pastebin/pastebin.php?show=1564
Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by Shatian »

So I'm wondering, did I submit this wrong? Can I get at least a yes or no about if it's possible that this could get added?
User avatar
s55
HandBrake Team
Posts: 10350
Joined: Sun Dec 24, 2006 1:05 pm

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by s55 »

Sorry, I just haven't had the time to look it over yet. It's on my todo list.
User avatar
s55
HandBrake Team
Posts: 10350
Joined: Sun Dec 24, 2006 1:05 pm

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by s55 »

Yeh, seems fine. I'll get it checked in later in the week/weekend when I have some time. I want to look at what the LinGUI is doing to try keep things consistent if possible. I know it's got an option to do with CC.
Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by Shatian »

Ok, thanks!
User avatar
s55
HandBrake Team
Posts: 10350
Joined: Sun Dec 24, 2006 1:05 pm

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by s55 »

Updated against head, tweaked slightly and checked in: https://trac.handbrake.fr/changeset/3485

Thanks! Sorry for the delay in getting around to it.
Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by Shatian »

Awesome! Thanks for including it. :)
Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by Shatian »

I just built it. It doesn't look like the subtitle check box is persisting, just to let you know.
User avatar
s55
HandBrake Team
Posts: 10350
Joined: Sun Dec 24, 2006 1:05 pm

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by s55 »

Post Reply