With upcoming changes to data protection and privacy laws in Europe coming into effect soon, we thought this would be a good time to remind everyone that we do have a privacy policy.
This applies to all users and visitors world-wide.

We have made a few changes to the language to make it clearer in relation to this new regulation but fundamentally, the terms and your rights are unchanged.

If you have any questions about this, please feel free to ask in the General Forum

[PATCH]Add new options for Subtitles in WinGUI

Developer discussion and patch submissions only!
Forum rules
This forum is for developer discussion and patch submission only.
Post Reply
Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

[PATCH]Add new options for Subtitles in WinGUI

Post by Shatian » Sun Aug 01, 2010 1:39 pm

I asked if this was possible and it was marked not planned, so I decided to give it a shot at writing it myself.

I added an extra option to tell the GUI to use my preferred language as both the subtitle and the audio track, I also added a check box to tell the GUI to used the Closed Caption track if it doesn't find a sub that matches the preferred language. I also fixed a few tool tips while I was making the changes.

I added these because I rip a lot of television series DVDs and wanted to be able to always pick the English sub and dub.

http://handbrake.fr/pastebin/pastebin.php?show=1564

Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by Shatian » Tue Aug 17, 2010 2:58 am

So I'm wondering, did I submit this wrong? Can I get at least a yes or no about if it's possible that this could get added?

User avatar
s55
HandBrake Team
Posts: 9078
Joined: Sun Dec 24, 2006 1:05 pm

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by s55 » Tue Aug 17, 2010 6:54 am

Sorry, I just haven't had the time to look it over yet. It's on my todo list.

User avatar
s55
HandBrake Team
Posts: 9078
Joined: Sun Dec 24, 2006 1:05 pm

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by s55 » Tue Aug 17, 2010 7:27 pm

Yeh, seems fine. I'll get it checked in later in the week/weekend when I have some time. I want to look at what the LinGUI is doing to try keep things consistent if possible. I know it's got an option to do with CC.

Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by Shatian » Fri Aug 20, 2010 12:13 am

Ok, thanks!

User avatar
s55
HandBrake Team
Posts: 9078
Joined: Sun Dec 24, 2006 1:05 pm

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by s55 » Fri Aug 20, 2010 7:16 pm

Updated against head, tweaked slightly and checked in: https://trac.handbrake.fr/changeset/3485

Thanks! Sorry for the delay in getting around to it.

Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by Shatian » Sat Aug 21, 2010 12:22 am

Awesome! Thanks for including it. :)

Shatian
Posts: 17
Joined: Wed Nov 11, 2009 12:31 am

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by Shatian » Sat Aug 21, 2010 12:27 am

I just built it. It doesn't look like the subtitle check box is persisting, just to let you know.

User avatar
s55
HandBrake Team
Posts: 9078
Joined: Sun Dec 24, 2006 1:05 pm

Re: [PATCH]Add new options for Subtitles in WinGUI

Post by s55 » Sat Aug 21, 2010 11:59 am


Post Reply