[PATCH] High quality AAC encoder on Mac OS X

Archive of historical development discussions
Discussions / Development has moved to GitHub
Forum rules
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.

*******************************
User avatar
Ritsuka
HandBrake Team
Posts: 1080
Joined: Fri Jan 12, 2007 11:29 am

Re: [PATCH] High quality AAC encoder on Mac OS X

Post by Ritsuka » Sat May 23, 2009 6:45 am

I think I am going to commit this soon after I add a better way to read the decoder specific info from the esds descriptor. Right now is a quite hacky and could break very easyly.

KonaBlend
Posts: 72
Joined: Tue Nov 04, 2008 2:35 am

Re: [PATCH] High quality AAC encoder on Mac OS X

Post by KonaBlend » Sat May 23, 2009 9:14 am

Anyone actually tried this patch on x86_64 build?
I'm thinking if it CoreAudio depends on QuickTime components of any kind... there might be an issue as they're 32-bit binaries.

User avatar
Ritsuka
HandBrake Team
Posts: 1080
Joined: Fri Jan 12, 2007 11:29 am

Re: [PATCH] High quality AAC encoder on Mac OS X

Post by Ritsuka » Sat May 23, 2009 9:49 am

Commited in rev 2441.
CoreAudio fortunately has not much too do with QuickTime and it's already 64 bit :)

cvk_b
Veteran User
Posts: 527
Joined: Sun Mar 18, 2007 2:11 am

Re: [PATCH] High quality AAC encoder on Mac OS X

Post by cvk_b » Sat May 23, 2009 11:05 am

Time to celebrate! Thanks.

laika 1957
Posts: 5
Joined: Fri May 15, 2009 11:50 pm

Re: [PATCH] High quality AAC encoder on Mac OS X

Post by laika 1957 » Sun May 24, 2009 2:27 pm

Small detail... The "ca_aac" choice should be mentioned here, in the --help output of test.c, the CLI tool :)

" -E, --aencoder <string> Audio encoder(s) (faac/lame/vorbis/ac3/dts) \n"

nightstrm
Veteran User
Posts: 1887
Joined: Fri Mar 23, 2007 5:43 am

Re: [PATCH] High quality AAC encoder on Mac OS X

Post by nightstrm » Mon May 25, 2009 3:38 am

Great news! Looks like I should finally stop being lazy and update from SVN and start testing some of the stuff added in the last few weeks. =)

Post Reply