Does this patch have new functionality, or simply an update so it compiles cleanly against SVN head?Ritsuka wrote:http://handbrake.fr/pastebin/pastebin.php?show=439
As always, thanks for maintaining this... I love the output of CoreAudio @ AAC 256.
Does this patch have new functionality, or simply an update so it compiles cleanly against SVN head?Ritsuka wrote:http://handbrake.fr/pastebin/pastebin.php?show=439
Code: Select all
Ld /usr/local/src/hbtrunk/build/HandBrake.app/Contents/MacOS/HandBrake normal i386
mkdir /usr/local/src/hbtrunk/build/HandBrake.app/Contents/MacOS
cd /usr/local/src/hbtrunk/macosx
setenv MACOSX_DEPLOYMENT_TARGET 10.5
/Developer/usr/bin/g++-4.0 -arch i386 -isysroot /Developer/SDKs/MacOSX10.5.sdk -L/usr/local/src/hbtrunk/build -F/usr/local/src/hbtrunk/build -F/usr/local/src/hbtrunk/macosx -F/usr/local/src/hbtrunk/macosx -filelist /usr/local/src/hbtrunk/build/macosx/HandBrake.build/Objects-normal/i386/HandBrake.LinkFileList -mmacosx-version-min=10.5 /usr/local/src/hbtrunk/build/libhb/libhb.a /usr/local/src/hbtrunk/build/contrib/lib/libmp4v2.a /usr/local/src/hbtrunk/build/contrib/lib/liba52.a /usr/local/src/hbtrunk/build/contrib/lib/libavformat.a /usr/local/src/hbtrunk/build/contrib/lib/libavcodec.a /usr/local/src/hbtrunk/build/contrib/lib/libavutil.a /usr/local/src/hbtrunk/build/contrib/lib/libdvdread.a /usr/local/src/hbtrunk/build/contrib/lib/libfaac.a /usr/local/src/hbtrunk/build/contrib/lib/libmp3lame.a /usr/local/src/hbtrunk/build/contrib/lib/libmpeg2.a /usr/local/src/hbtrunk/build/contrib/lib/libvorbis.a /usr/local/src/hbtrunk/build/contrib/lib/libvorbisenc.a /usr/local/src/hbtrunk/build/contrib/lib/libogg.a /usr/local/src/hbtrunk/build/contrib/lib/libsamplerate.a /usr/local/src/hbtrunk/build/contrib/lib/libx264.a /usr/local/src/hbtrunk/build/contrib/lib/libxvidcore.a /usr/local/src/hbtrunk/build/contrib/lib/libdca.a /usr/local/src/hbtrunk/build/contrib/lib/libmkv.a /usr/local/src/hbtrunk/build/contrib/lib/libswscale.a /usr/local/src/hbtrunk/build/contrib/lib/libtheora.a /usr/local/src/hbtrunk/build/contrib/lib/libfaad.a -lbz2 -lz -framework Cocoa -framework Quartz -framework QTKit -framework OpenGL -framework IOKit -lz -framework Growl -framework Sparkle -framework AudioToolbox -o /usr/local/src/hbtrunk/build/HandBrake.app/Contents/MacOS/HandBrake
Undefined symbols:
"_hb_encca_aac", referenced from:
_hb_encca_aac$non_lazy_ptr in libhb.a(hb.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status
PBXCp /usr/local/src/hbtrunk/build/HandBrake.app/Contents/Frameworks/Growl.framework Growl.framework
mkdir /usr/local/src/hbtrunk/build/HandBrake.app/Contents/Frameworks
cd /usr/local/src/hbtrunk/macosx
/Developer/Library/PrivateFrameworks/DevToolsCore.framework/Resources/pbxcp -exclude .DS_Store -exclude CVS -exclude .svn -strip-debug-symbols -resolve-src-symlinks /usr/local/src/hbtrunk/macosx/Growl.framework /usr/local/src/hbtrunk/build/HandBrake.app/Contents/Frameworks
PBXCp /usr/local/src/hbtrunk/build/HandBrake.app/Contents/Frameworks/Sparkle.framework Sparkle.framework
cd /usr/local/src/hbtrunk/macosx
/Developer/Library/PrivateFrameworks/DevToolsCore.framework/Resources/pbxcp -exclude .DS_Store -exclude CVS -exclude .svn -strip-debug-symbols -resolve-src-symlinks /usr/local/src/hbtrunk/macosx/Sparkle.framework /usr/local/src/hbtrunk/build/HandBrake.app/Contents/Frameworks
** BUILD FAILED **
The following build commands failed:
HandBrakeCLI:
Ld /usr/local/src/hbtrunk/build/HandBrakeCLI normal i386
HandBrake:
Ld /usr/local/src/hbtrunk/build/HandBrake.app/Contents/MacOS/HandBrake normal i386
(2 failures)
make: *** [macosx.build] Error 1
http://handbrake.fr/irclogs/handbrake-d ... 1_pg2.html:jzietman wrote:Is there any chance that this will ever be committed to trunk?
[19:27] [jbrjake] KonaB1end: what's the plan for platform-specific stuff?
[19:28] [KonaB1end] jbrjake: docwise?
[19:28] [jbrjake] sorry i mean code
[19:28] [KonaB1end] libhb uses the same mechanism .
[19:28] [jbrjake] like saintdev was talking about the other day with asm for yadif
[19:28] [KonaB1end] oh,
[19:29] [KonaB1end] we have many methods of compiling optional files.
[19:29] [KonaB1end] we can key off:
[19:29] *** jbrjake is just curious if the new build system might allow the possibility of being extended to do stuff like ritsuka's core audio patch in an elegant way that keeps the code separate from the main body
[19:29] [KonaB1end] absolutely.
[19:29] [KonaB1end] refer to libhb/module.defs
[19:30] [KonaB1end] at bottom is just an example of conditional defines keying off $(BUILD.system)
[19:30] [KonaB1end] features can be done too.
[19:30] [KonaB1end] ie: we can add configure --enable-ritsuka
[19:31] [KonaB1end] and then FEATURE.ritsuka = 1 would show up to make .
[19:31] [jbrjake] ritsuka: and yes, that means i will stop my b*tching and let you check it in, if it's all segmented from the vanilla code
Oh I agree that what you proposed earlier in the thread is clearly the optimal solution, with a sort of plug-in system for code to register itself....but we've been waiting awhile now and no one's done that, and the perfect shouldn't be the enemy of the good.eddyg wrote:The problem was never the build system, but how to have optional modules linked in and auto discovered and enabled without the core code knowing that they exist prior to that point.
Just built with your patch and 'disable-xcode'. Compiled fine. Test chapter encodes seem fine. Thanks.Ritsuka wrote:As jbrjake gave his approval to commit the patch to svn, I post here an updated version for review/comment. If no one complains I'll commit it soon.
http://pastie.org/426557
Just some heads up...Ritsuka wrote:As jbrjake gave his approval to commit the patch to svn, I post here an updated version for review/comment. If no one complains I'll commit it soon.
http://pastie.org/426557
That would most likely break subtitle support.laika 1957 wrote: Simply commenting this line out makes the build succeed, and the CA AAC seems to work fine..