[Patch] Detect any Windows OS when using Cygwin and make

Archive of historical development discussions
Discussions / Development has moved to GitHub
Forum rules
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.

*******************************
Post Reply
Lant
Regular User
Posts: 70
Joined: Wed May 02, 2007 5:33 pm

[Patch] Detect any Windows OS when using Cygwin and make

Post by Lant »

At the moment every time there is an update to one of the makefiles I have to hack it so that it detects that I am using cygwin on Vista. This means changing lots of CYGWIN_NT-5.1 to CYGWIN_NT-6.0-WOW64.

Patch at http://pastebin.com/m75e9873f means that it just looks for CYGWIN_NT in the $(SYSTEM) instead.
User avatar
s55
HandBrake Team
Posts: 9939
Joined: Sun Dec 24, 2006 1:05 pm

Post by s55 »

Thanks,

Will probably check this in on Friday afternoon after I confirm that it works ok.
Lant
Regular User
Posts: 70
Joined: Wed May 02, 2007 5:33 pm

Post by Lant »

Just tried to compile Handbrake without modifying the makefiles and noticed that the Makefile in the top directory was missing a change. (line 67)
User avatar
s55
HandBrake Team
Posts: 9939
Joined: Sun Dec 24, 2006 1:05 pm

Post by s55 »

woops, forgot to checkin the file.

http://handbrake.m0k.org/trac/changeset/1129

Your best using JAM. The contrib pack for make is rather out of date atm. May cause problems with 1 or 2 of the new features.
Post Reply