question about subtitle indepth_scan without native
Forum rules
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.
*******************************
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.
*******************************
- JohnAStebbins
- HandBrake Team
- Posts: 5723
- Joined: Sat Feb 09, 2008 7:21 pm
question about subtitle indepth_scan without native
What is it for? I've been testing subtitles today in the gui I'm writing. This subtitle option has me mystified. It seems to only select a subtitle if there are more than one. And then it will only select one if it has 1/10 the hits (fewer subtitles) than the others. Not what I expected. Had me chasing phantom bugs for a while.
Also, I was looking through the mac gui code and didn't see any support for the native language feature. hb_add does something a little strange with native_language. It seems to expect the caller to malloc the space for native_language, and if it determines it isn't needed hb_add free's it.
Also, I was looking through the mac gui code and didn't see any support for the native language feature. hb_add does something a little strange with native_language. It seems to expect the caller to malloc the space for native_language, and if it determines it isn't needed hb_add free's it.
Re: question about subtitle indepth_scan without native
Well, if your referring to picking the native language from the prefs, then it's here in titlePopUpChanged in Controller.mm line 2198:JohnAStebbins wrote:Also, I was looking through the mac gui code and didn't see any support for the native language feature.
Code: Select all
/* search for the first instance of our prefs default language for track 1, and set track 2 to "none" */
NSString * audioSearchPrefix = [[NSUserDefaults standardUserDefaults] stringForKey:@"DefaultLanguage"];
[self selectAudioTrackInPopUp: fAudLang1PopUp searchPrefixString: audioSearchPrefix selectIndexIfNotFound: 1];
- JohnAStebbins
- HandBrake Team
- Posts: 5723
- Joined: Sat Feb 09, 2008 7:21 pm
Re: question about subtitle indepth_scan without native
Thanks for the response. The DefaultLanguage you refer to seems to be only used for selecting an audio track. I'm refering to job->native_language. This affects which subtitle is chosen. If set AND the audio language is different, hb_add will automaitcally subtitles for the native language if available. The CLI has an option to use this.
Do you have any insight into what the "Autoselect" option is meant to be used for. As I said before, it only adds subtitles if it finds more than one subtitle track and the track with the LEAST hits (number of subtitles?) will be added ONLY if it less than 1/10 of the hits of the track with the most hits.
Do you have any insight into what the "Autoselect" option is meant to be used for. As I said before, it only adds subtitles if it finds more than one subtitle track and the track with the LEAST hits (number of subtitles?) will be added ONLY if it less than 1/10 of the hits of the track with the most hits.
Re: question about subtitle indepth_scan without native
Well, yes eddyg developed all of that. I know autoselect is to be used mainly in conjunction with forced subtitles. Now I do remember the Native Language and how it was to work with subtitles, the idea was that the user could specify their native language in the gui prefs then choose whether or not to use dubbed audio or subtitles if the source was not originally in their native language. Then if they chose subtitles the idea was that it would search for the subtitles in their native language. However at the time it seemed to have some issues and so we pulled it from the macgui right before a release ... I think it was right before 0.9.0. At any rate you are right, that native language has been pretty much "resting" gui wise until eddyg decides to revisit it afaik. If it were me writing a gui I would do the same for now.
Re: question about subtitle indepth_scan without native
Autoselect is meant to automatically select a subtitle track if it is determined small enough to likely be a separate subtitle track used to show subtitles in a foreign language scene. This was the original "forced" subtitle support that was included in Handbrake, which has since gotten full forced subtitle support (i.e. subtitles flagged as forced from the main subtitle track).JohnAStebbins wrote:Thanks for the response. The DefaultLanguage you refer to seems to be only used for selecting an audio track. I'm refering to job->native_language. This affects which subtitle is chosen. If set AND the audio language is different, hb_add will automaitcally subtitles for the native language if available. The CLI has an option to use this.
Do you have any insight into what the "Autoselect" option is meant to be used for. As I said before, it only adds subtitles if it finds more than one subtitle track and the track with the LEAST hits (number of subtitles?) will be added ONLY if it less than 1/10 of the hits of the track with the most hits.
- JohnAStebbins
- HandBrake Team
- Posts: 5723
- Joined: Sat Feb 09, 2008 7:21 pm
Re: question about subtitle indepth_scan without native
It sounds like Autoselect has be marginalized by the forced option. I'm considering removing it from my gui. Does that seem reasonable?
Re: question about subtitle indepth_scan without native
Well, for my part I would for a first cut. As a compromise we just included Autoselect and Forced in the macgui, but as I said generally speaking you would use both together as I understand it.JohnAStebbins wrote:I'm considering removing it from my gui. Does that seem reasonable?
Re: question about subtitle indepth_scan without native
not all DVDs which include subs for foreign language segments use forced subtitles. That's why the feature should remain. The ideal solution is to implement the DVDs virtual machine, which will select the correct subtitles track in the first place.
As for native language, dynaflash was correct. The theory I'd to select the native language of the viewers audio or subtitles tracks when the movie isn't in it. This is in the cli.
Cheers, ed.
As for native language, dynaflash was correct. The theory I'd to select the native language of the viewers audio or subtitles tracks when the movie isn't in it. This is in the cli.
Cheers, ed.
- JohnAStebbins
- HandBrake Team
- Posts: 5723
- Joined: Sat Feb 09, 2008 7:21 pm
Re: question about subtitle indepth_scan without native
I haven't removed Autoselect yet, so I guess I'll leave it in. I was just very surprised when I selected autoselect and got no subtitles whatsoever in the output. I've been trying to think of some way to designate this in the UI so that users aren't as surprised as I was.
The native language thing looks like it should work fine. There's just that funny thing about libhb freeing something it didn't allocate. If It weren't for that, I would have built in support for it as well.
The native language thing looks like it should work fine. There's just that funny thing about libhb freeing something it didn't allocate. If It weren't for that, I would have built in support for it as well.
Re: question about subtitle indepth_scan without native
Both the autoselect and native subs feel a little hacky. I haven't returned to them as yet, based on principle that if it isn't broken...
Cheers, Ed.
Cheers, Ed.