Page 1 of 1

Progress printed on different lines

Posted: Wed Jun 14, 2017 3:14 pm
by DougH
I'verecently upgraded to version 20170613212211-16cc030-master from version 20170102135948-3155365-master.

My operating system is Windows 7.

Now when I run a encoding job the progress is displayed as follows:

Code: Select all

Encoding: task 1 of 2, 0.05 % (0.00 fps, avg 0.00 fps, ETA 00h03m43s)
Encoding: task 1 of 2, 0.10 % (0.00 fps, avg 0.00 fps, ETA 00h05m13s)
Encoding: task 1 of 2, 0.24 % (0.00 fps, avg 0.00 fps, ETA 00h03m37s)
Encoding: task 1 of 2, 0.37 % (0.00 fps, avg 0.00 fps, ETA 00h03m12s)
Encoding: task 1 of 2, 0.52 % (0.00 fps, avg 0.00 fps, ETA 00h02m57s)
Encoding: task 1 of 2, 0.68 % (0.00 fps, avg 0.00 fps, ETA 00h02m43s)
Encoding: task 1 of 2, 0.81 % (0.00 fps, avg 0.00 fps, ETA 00h02m41s)
Encoding: task 1 of 2, 0.92 % (0.00 fps, avg 0.00 fps, ETA 00h02m44s)
Encoding: task 1 of 2, 1.05 % (0.00 fps, avg 0.00 fps, ETA 00h02m43s)
Encoding: task 1 of 2, 1.17 % (0.00 fps, avg 0.00 fps, ETA 00h02m43s)
Encoding: task 1 of 2, 1.24 % (0.00 fps, avg 0.00 fps, ETA 00h02m50s)
Encoding: task 1 of 2, 1.29 % (0.00 fps, avg 0.00 fps, ETA 00h02m58s)
In my previous version the progress was only shown on asingle line. Which file do I need to chagne on my system so I can revert back to the old style of progress using the smae line rather then a new line ever time?

Re: Progress printed on different lines

Posted: Wed Jun 14, 2017 3:36 pm
by mduell
How are you running it?

Re: Progress printed on different lines

Posted: Wed Jun 14, 2017 4:19 pm
by DougH
The command I'm using is:

Code: Select all

handbrakecli -i ftest.mkv -o ftest.mp4 --preset-import-file H265Stereo.json 2> ftest.log
The encoding itself works fine. It's just the pgoress updating with a new line ever time I find annoying.

Re: Progress printed on different lines

Posted: Thu Jun 15, 2017 3:21 am
by BradleyS
We recently made a change to how piped output is created, but it shouldn't affect usage in a terminal window. Are you only seeing this in a piped .log file, or in the terminal itself?

Re: Progress printed on different lines

Posted: Thu Jun 15, 2017 12:11 pm
by DougH
I just tried the same command but left off the 2> ftest.log and received the same result. This behavior only happens on Windows. I built the same nightly for Linux and I got the expected behavior of the progress indication using the same line.

Re: Progress printed on different lines

Posted: Thu Jun 15, 2017 6:51 pm
by BradleyS
Okay, thanks for checking that.

This is the commit I'm concerned about: https://github.com/HandBrake/HandBrake/ ... 7177f54a24

Is there any chance you can build the commit before that on master branch and see if that solves the problem? If so, I'll need to investigate why isatty() isn't working on Windows.

Re: Progress printed on different lines

Posted: Thu Jun 15, 2017 9:01 pm
by DougH
Yes, I'll do a build this evening and let you know what happens.

Re: Progress printed on different lines

Posted: Thu Jun 15, 2017 10:58 pm
by DougH
I've just built Handbrake from this commit (which is the parent of the one mentioned above).

https://github.com/HandBrake/HandBrake/ ... cb90106f20

The behavior of the progress indicator is back using a single line both with and without pipe redirection.

Re: Progress printed on different lines

Posted: Thu Jun 15, 2017 11:02 pm
by BradleyS
Thanks for double checking that for me. I'll try to reproduce (and hopefully resolve) the issue over the weekend.

Re: Progress printed on different lines

Posted: Sat Jun 17, 2017 7:41 pm
by BradleyS

Re: Progress printed on different lines

Posted: Sat Jun 17, 2017 7:43 pm
by BradleyS

Re: Progress printed on different lines

Posted: Sun Jun 18, 2017 1:32 am
by DougH
I will compile it as soon as the bad weather passes by. Thank you for looking into this.