ReviewBoard and Patch Submissions

[HandBrake]

We now have a reviewboard setup at
https://reviews.handbrake.fr

Before Starting

Before spending a lot of time developing a patch, it's worth discussion it on irc or the forums here first.
It will avoid tears later if it turns out someone else is working on something similar, or it's a feature we simply don't wish to add to HandBrake.

A word of warning if you are working with our GitHub repository. Git Diffs are a bit difficult to use with Reviewboard with our current setup, so it's recommended to use an svn diff instead.

Posting a Review

If you don't already have an account, sign-up.

You'll want to create an svn diff against our svn repository code and post it up for review.
At this time, it doesn't work well with git diffs and you may find it easier to create an svn diff.

Please fill out both the description and testing boxes describing the work that you have done in appropriate detail. Feel free to add attachments and screenshots that demonstrate the work.

What happens next?

Developers and users with review board accounts can comment on your patch. After discussion, you can submit an updated diff file by clicking the "Update Diff" button on the review. This cycle will repeat until the patch is in a suitable form.

When finished a developer will sign off on the change (by marking it as "Ship It") and get it committed to the repository if you don't yourself have svn access.

What will help get the patch submitted faster?

* Provide a patch which is well documented with code-comments.
* Thoroughly test it and document your test results in the review "Testing" section.