Page 1 of 1

[PATCH]Add new options for Subtitles in WinGUI

Posted: Sun Aug 01, 2010 1:39 pm
by Shatian
I asked if this was possible and it was marked not planned, so I decided to give it a shot at writing it myself.

I added an extra option to tell the GUI to use my preferred language as both the subtitle and the audio track, I also added a check box to tell the GUI to used the Closed Caption track if it doesn't find a sub that matches the preferred language. I also fixed a few tool tips while I was making the changes.

I added these because I rip a lot of television series DVDs and wanted to be able to always pick the English sub and dub.

http://handbrake.fr/pastebin/pastebin.php?show=1564

Re: [PATCH]Add new options for Subtitles in WinGUI

Posted: Tue Aug 17, 2010 2:58 am
by Shatian
So I'm wondering, did I submit this wrong? Can I get at least a yes or no about if it's possible that this could get added?

Re: [PATCH]Add new options for Subtitles in WinGUI

Posted: Tue Aug 17, 2010 6:54 am
by s55
Sorry, I just haven't had the time to look it over yet. It's on my todo list.

Re: [PATCH]Add new options for Subtitles in WinGUI

Posted: Tue Aug 17, 2010 7:27 pm
by s55
Yeh, seems fine. I'll get it checked in later in the week/weekend when I have some time. I want to look at what the LinGUI is doing to try keep things consistent if possible. I know it's got an option to do with CC.

Re: [PATCH]Add new options for Subtitles in WinGUI

Posted: Fri Aug 20, 2010 12:13 am
by Shatian
Ok, thanks!

Re: [PATCH]Add new options for Subtitles in WinGUI

Posted: Fri Aug 20, 2010 7:16 pm
by s55
Updated against head, tweaked slightly and checked in: https://trac.handbrake.fr/changeset/3485

Thanks! Sorry for the delay in getting around to it.

Re: [PATCH]Add new options for Subtitles in WinGUI

Posted: Sat Aug 21, 2010 12:22 am
by Shatian
Awesome! Thanks for including it. :)

Re: [PATCH]Add new options for Subtitles in WinGUI

Posted: Sat Aug 21, 2010 12:27 am
by Shatian
I just built it. It doesn't look like the subtitle check box is persisting, just to let you know.

Re: [PATCH]Add new options for Subtitles in WinGUI

Posted: Sat Aug 21, 2010 11:59 am
by s55