Archive of historical development discussions
Discussions / Development has moved to GitHub
Forum rules
******************************* Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.
The only issue I've seen is when there are multiple subtitles appearing on screen at the same time, during opening sequences with music lyrics and dialogue, for example. This is should be expected and is just the nature of the beast, IMO. Watching the encoded video, it looks like it tries to display all subtitles, but gets behind. It will eventually sync it self up again once subtitle activity has decreased.
SSA->UTF-8 subtitle decoder. Contributed by davidfstr.
* Also slightly improved out-of-memory handling in the TX3G subtitle decoder.
I have tested this with the following interesting subtitles:
1. aaa{\b1\i1}bbbcccdddeeefff
2. aaa{\u1\b1}bbb{\b0\be1\i1\u0}cccdddeeefff
3. aaa{\u1\b1}bbb{\i1}cccdddeeefff
4. aaa{\u1\b1}bbb{\i1\b0}cccdddeeefff
any substitle rendered in HB should not be input type specific. Instead it should render the plain utf text subs in the hb subtitle packets. If the markup becomes an issue we'll have to specify what the expected format is in a hb sub.
In the case of rendered SSA subs, I wasn't going to use the UTF-8 text at all.
I was planning on modifying dec-ssa-sub to use libass to create an output packet in the PICTURESUB format when the subtitle track is configured to output to PICTURESUB. If the output format is TEXTSUB, dec-ssa-sub would use the behavior indicated in this patch.
In case I was unclear, this patch is ready for review. I will be doing SSA burn-in in a separate patch.
Think this might have broke building, at least on OSX for me. Link error with _hb_decssasub undefined.
This is with a clean checkout of svn3342 on a core 2 duo mac, previously successfully used to build several earlier svn versions up to and including svn3339 yesterday.
(As I just reported a subtitling related bug seen on svn3339 and svn3340 and i just saw these committed I thought I'd look see if there was any difference or anything more in activity log. But can't as it won't build. )