[PATCH] Universal VOB subtitle input
Forum rules
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.
*******************************
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.
*******************************
Re: [PATCH] Universal VOB subtitle input
Cool.Rodeo wrote:Fix works
Re: [PATCH] Universal VOB subtitle input
CLI Query: "--subtitle 1,2,3,4 --subtitle-burn=1"
Log: [20:45:14] * subtitle track 1, English (id 20bd) Picture [VOBSUB] -> Render/Burn in
Is there something special needed to make this work at the CLI?
Log: [20:45:14] * subtitle track 1, English (id 20bd) Picture [VOBSUB] -> Render/Burn in
Is there something special needed to make this work at the CLI?
- JohnAStebbins
- HandBrake Team
- Posts: 5726
- Joined: Sat Feb 09, 2008 7:21 pm
Re: [PATCH] Universal VOB subtitle input
Code: Select all
HandBrakeCLI -Z Normal --subtitle 1,2,3 --subtitle-burn=1 -t 1 -i Alien\ Resurection.iso -o ttt.mp4 -c 4
Code: Select all
[14:17:37] * subtitle track 1, English (Closed Caption) (id 23bd) Picture [VOBSUB] -> Render/Burn in
[14:17:37] * subtitle track 2, Espanol (id 24bd) Picture [VOBSUB] -> Pass-Through
[14:17:37] * subtitle track 3, Francais (id 25bd) Picture [VOBSUB] -> Pass-Through
Re: [PATCH] Universal VOB subtitle input
Was working against the wrong cli build.
Re: [PATCH] Universal VOB subtitle input
Yep. The CLI code that displays the error message you mention was removed in http://trac.handbrake.fr/changeset/3325 along with the rest.s55 wrote:Was working against the wrong cli build.
- JohnAStebbins
- HandBrake Team
- Posts: 5726
- Joined: Sat Feb 09, 2008 7:21 pm
Re: [PATCH] Universal VOB subtitle input
Committed http://trac.handbrake.fr/changeset/3337davidfstr wrote:Patch to fix the VOB palette colors when reading from an MP4:
http://handbrake.fr/pastebin/pastebin.php?show=1439
Strangely, I seemed to be getting the correct colors even without this patch, even though decvobsub was complaining. Need another tester to make sure this works.
I added preservation of width and height values as well.
Thanks davidfstr
Re: [PATCH] Universal VOB subtitle input
Thanks John tooJohnAStebbins wrote:Committed http://trac.handbrake.fr/changeset/3337davidfstr wrote:Patch to fix the VOB palette colors when reading from an MP4:
http://handbrake.fr/pastebin/pastebin.php?show=1439
Strangely, I seemed to be getting the correct colors even without this patch, even though decvobsub was complaining. Need another tester to make sure this works.
I added preservation of width and height values as well.
Thanks davidfstr
One question: you have a check for subtitle width or height being 0, and if you encounter that, you hardcode 720 x 480. Would it make sense to move the check to the muxer, or anywhere else where title->width and title->height are available, and use those values instead?
- JohnAStebbins
- HandBrake Team
- Posts: 5726
- Joined: Sat Feb 09, 2008 7:21 pm
Re: [PATCH] Universal VOB subtitle input
You don't want to use title width and height. The width and height in vobsubs is suppose to be the original width and height of the source the vobsub came from. So an mkv could have a video resolution of 720x384 because of cropping, but the subtitle resolution should be 720x480 (assuming ntsc). Players use the original dimensions of the source to properly scale the position and size information that is contained in the individual subtitles contained in a vobsub stream. Since these parameters are not changed when passing the vobsub through, they are relative to the original source dimensions.
Re: [PATCH] Universal VOB subtitle input
Seemed to me assuming 720 x 480 was equally bad - though it's true that VOBSUBs do originate from DVD sources so it's safer than I originally thought.
But PAL users are screwed
But PAL users are screwed
- JohnAStebbins
- HandBrake Team
- Posts: 5726
- Joined: Sat Feb 09, 2008 7:21 pm
Re: [PATCH] Universal VOB subtitle input
Using the ntsc dimensions as a default means that the subtitles from a pal source would be shown closer to the bottom of the screen. All players I know of test the values so that they don't go below the bottom. And mplayer places the subs too high anyway, so having them go a little lower doesn't hurt