[Patch] [MacGUI] Make Core Audio the default AAC encoder

[Deleted User 11865]

Since CoreAudio is better than faac, I don't see why it shouldn't be the default AAC encoder in the MacGUI.

Currently, when the source isn't AC3/DTS and we select AC3/DTS passthrough, the encoder is reset to faac. Same thing happens when loading a preset that has an AC3/DTS passthrough track when the source has no compatible track. Moreover, when a new audio track is added, since faac is at the top of every audio popup, it's also selected by default.

The following patch makes CoreAudio the default AAC encoder by placing it at the top of the audio popups and selecting it instead of faac as a fallback for AC3/DTS passthrough (and also removes some legacy AVI/OGM code):

http://handbrake.fr/pastebin/pastebin.php?show=1245

[dynaflash]

Okay, after discussion on irc, it was decided that the "Use CoreAudio instead of FAAC" encoder should just be applied to built in presets, as when it is on the user can not make a custom preset that uses faac as it gets overridden.

This patch is the above with the addition of only applying that preference to the built in presets so the user can decide for themselves what encoder to use for custom presets.

http://handbrake.fr/pastebin/pastebin.php?show=1246

[dynaflash]

Committed as http://trac.handbrake.fr/changeset/3138

Thanks Rodeo!

[Chris_BBR]

Will this new default also be reflected in the CLI presets under OS X, or will we have to manually opt for '-E ca_aac' ?

Cheers, Chris

[Deleted User 11865]

Will this new default also be reflected in the CLI presets under OS X, or will we have to manually opt for '-E ca_aac' ?

It'll still be opt-in. Controller.m is a Mac-only file, it doesn't get built on any other platform - to make ca_aac default in the Mac CLI, we'd have to use ifdefs all over the place - which is ugly and hard to maintain (not to mention that the CLI presets are parsed from the MacGUI presets by a script so said script would have to manage/account for the ifdefs).