[PATCH] Include all audio and subtitle tracks

Archive of historical development discussions
Discussions / Development has moved to GitHub
Forum rules
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.

*******************************
Post Reply
priikone
Posts: 2
Joined: Wed Feb 03, 2010 9:12 pm

[PATCH] Include all audio and subtitle tracks

Post by priikone »

Hello,

The enclosed patch adds support to core and HandBrakeCLI for including all audio tracks and/or all subtitle tracks, instead of requiring user to specify tracks explicitly. This allows easily to do one-to-one "copy" of your DVD with all audio tracks and subtitles just by doing:

HandBrakeCLI -i /dev/dvd -o movie.mkv -L -a all -s all

Functionality:

- MKV container is required to be able to add all subtitles
- Subtitles cannot be burned in when "all" is used
- Default subtitle cannot be specified (with HandBrakeCLI)
- All audio related options apply to all audio tracks, unless separated by commas for specific tracks (eg. with -B 192 applies to all but with -B 192,224 the 192 applies to first track and 224 for second. If there are more than two tracks in the previous example all the remaining tracks would use 192).

Patch against HEAD: http://handbrake.fr/pastebin/pastebin.php?show=1185
eddyg
Veteran User
Posts: 798
Joined: Mon Apr 23, 2007 3:34 am

Re: [PATCH] Include all audio and subtitle tracks

Post by eddyg »

Sounds like a good feature to me.

Haven't looked at the code as yet, still waiting for my computer to be shipped to new house.

Cheers Ed.
User avatar
JohnAStebbins
HandBrake Team
Posts: 5712
Joined: Sat Feb 09, 2008 7:21 pm

Re: [PATCH] Include all audio and subtitle tracks

Post by JohnAStebbins »

I looked at it. Adding hb_audio_add_all and hb_subtitle_add_all to the core libhb isn't the way I would go. This implementation is only useful to the cli, so my preference would be that changes were limited to the cli.
priikone
Posts: 2
Joined: Wed Feb 03, 2010 9:12 pm

Re: [PATCH] Include all audio and subtitle tracks

Post by priikone »

Hello,

Certainly, CLI-only version can be done. The enclosed patch does that. It also respects the --subtitle-default, what the old versions didn't do.

Patch against HEAD: http://handbrake.fr/pastebin/pastebin.php?show=1220
Post Reply