Add NASM To Toolchains?

Developer discussion and patch submissions only!
Forum rules
This forum is for developer discussion and patch submission only.
Post Reply
WhatZit
Posts: 77
Joined: Sat Feb 13, 2016 2:45 am

Add NASM To Toolchains?

Post by WhatZit » Sun Dec 03, 2017 1:22 am

In order to support AVX-512 SIMD, both x264 & x265 are swapping from YASM to NASM.

Great! Only problem is that x265 v2.7 will require a very recent minimum (v2.13), and Ubuntu 16.04 only has a v2.11 package, and 17.04 a v2.12 package.

Sure, any user could just download the v2.13.xx tarball and make it themselves, but are there any plans to add NASM to your toolchains (mingw-w64-build script) instead?

EDIT: Just noticed that, 6 years earlier, you'd implemented an "autotools" solution for the same sort of thing involving YASM: make/configure.py Line 1587 "## enable local yasm when yasm probe fails or version is too old".
Last edited by WhatZit on Sun Dec 03, 2017 7:27 am, edited 1 time in total.

WhatZit
Posts: 77
Joined: Sat Feb 13, 2016 2:45 am

Add NASM To Toolchains?

Post by WhatZit » Sun Dec 03, 2017 4:26 am

BTW, I've just built HB with the very latest x265 v2.6+8 (fc0570b) which requires NASM, and it works fine.

Although it did take significantly longer than YASM, it produced slightly bigger files, and spewed out an x265 version of 0.0.

User avatar
BradleyS
Moderator
Posts: 1123
Joined: Thu Aug 09, 2007 12:16 pm

Re: Add NASM To Toolchains?

Post by BradleyS » Sun Dec 03, 2017 10:56 pm

We’ll add nasm when we update x264 and x265 again. These are locked for HandBrake 1.1.0, so it will be master branch sometime after that and then 1.2.0.

Post Reply