Real AAC VBR mode!

[jacop89]

https://reviews.handbrake.fr/r/514/

Which version was used at the time?
Why not try again the vbr mode test, with the latest version of the encoder (3.4.12) released in November 2014?

https://android.googlesource.com/platfo ... nc_lib.cpp
http://wiki.hydrogenaud.io/index.php?ti ... er_FDK_AAC


With the "dbpoweramp" music converter, works perfectly!

[jacop89]

Any news on that?
When will be implemented FDK AAC VBR mode in Handbrake?

[K@mpfH@mster]

Please update FDK AAC fast and make a real VBR mode. THX

[s55]

The request has already been made. There is no need to repeat it.

Be Patient or contribute a patch.

[jacop89]

The request has already been made. There is no need to repeat it.

Be Patient or contribute a patch.

Thank you as always for your continuous work!
I would just like to know if the feature request will be implemented and when...

What will be the tag that you would give to this feature request? [Planned], [Accepted] or [InProgress]?
Thanks!

[moneymatt4life]

... since it's already on review board, i'd guess InProgress? just hasn't been looked at in well over a year (2mo6days and it'll be 2 years)

[Deleted User 11865]

It doesn't work with the current FDK we're using; we could try updating to a newer FDK and testing it again.

[jacop89]

It doesn't work with the current FDK we're using; we could try updating to a newer FDK and testing it again.

What is the version of "FDK-AAC" used at the moment by "Handbrake"?

The latest "fdk-aac" library it the "0.1.4" (2015-03-11) based on FDK AAC (3.4.12/2.5.10), by Martin Storsjö.

http://sourceforge.net/projects/opencore-amr/

https://github.com/mstorsjo/fdk-aac

[s55]

Stop pushing...

It really doesn't matter what version we are using. We can upgrade at any time we please and if the problem is fixed, it'll allow us to enable VBR.

This is a hobby project, so people work on things that *interest them and on their own schedule*.

[jacop89]

Stop pushing...

It really doesn't matter what version we are using. We can upgrade at any time we please and if the problem is fixed, it'll allow us to enable VBR.

This is a hobby project, so people work on things that *interest them and on their own schedule*.

It is not my intention to press you, developers. I understand the hard work you do with passion and dedication.

I just wanted to point out that with the latest version of the program, the AAC "VBR" mode should work without problems, because in similar programs (such as "dBpowerAMP") works fine.

That's all.
Love&Peace!

[jacop89]

Sorry double post!

[jacop89]

Triple post... very sorry!!!

[jacop89]

https://trac.handbrake.fr/changeset/7145
https://trac.handbrake.fr/changeset/7146

Finally FDK-AAC VBR mode is coming ...
right?
With this new version works properly?

[moneymatt4life]

well, that's just a version bump...

but seeing as they can get it work now, it looks like it's finally coming soon

[jacop89]

well, that's just a version bump...

but seeing as they can get it work now, it looks like it's finally coming soon

I think so...

https://reviews.handbrake.fr/r/514/

[arcuser]

https://trac.handbrake.fr/changeset/7145
https://trac.handbrake.fr/changeset/7146

Finally FDK-AAC VBR mode is coming ... right?
With this new version works properly?

well, that's just a version bump...
but seeing as they can get it work now, it looks like it's finally coming soon

I think so...
https://reviews.handbrake.fr/r/514/

That fix was to amend an encoding speed issue...

However, in the latest version 0.1.4 of the FDK - it still says:
"VBR mode is not officially supported, and works only on a certain combination of parameter settings, sample rate, and channel configuration"

It has said this since the beginning though so that doesn't mean much

I'm guessing that it is mentioned to cover all eventualities.

[moneymatt4life]

did that really help with encoding speeds? because

0.1.4 has no speed improvements over 0.1.1

either way, it doesn't affect me... since i have a crap-ish CPU(i3-2330m) and i use versylow x264 preset
i think handbrake defaults to using afterburner... which is a higher quality, but slower, optimization... so i'd guess if anything were to affect speed, it would be that

that was probably when it could crash because of the lower GetInvInt table limit value...
although yeah, i don't see any mention of vbr in the official fdk document thing...

[arcuser]

did that really help with encoding speeds? because

0.1.4 has no speed improvements over 0.1.1

Yes, it most definitely has.

It wasn't the bump to 0.1.4., it was the use of compiler optimizations that has made a massive improvement (as noted in Review Request 819 https://reviews.handbrake.fr/r/819/)

However, it is also noted in the Review Request 514 that the bump to 0.1.4 seems to have solved the VBR issue. There have obviously been improvement in VBR somewhere between 0.1.1 and 0.1.4

That exact same note has been in FDK for years though - so it may be that the FDK codec is just trying to cover itself against unexpected output by saying "well we told that that VBR didn't work properly", as maybe they may feel they have still not perfected it to their liking

[JohnAStebbins]

FYI, I also fixed the compiler optimization issue in our 0.10.x bug fix branch. So our next bug fix release will have faster fdk-aac. It will still be 0.1.1, but it will be faster.

[arcuser]

FYI, I also fixed the compiler optimization issue in our 0.10.x bug fix branch. So our next bug fix release will have faster fdk-aac. It will still be 0.1.1, but it will be faster.

Does this mean we will see it in 0.10.2?

Any reason for keeping FDK 0.1.1 in the bug fix version rather than sticking to FDK 0.1.4 as now found in the nightlies? (Particularly as mentioned that the bump to 0.1.4 has fixed the VBR issues).

[JohnAStebbins]

Does this mean we will see it in 0.10.2?

yes

Any reason for keeping FDK 0.1.1 in the bug fix version rather than sticking to FDK 0.1.4 as now found in the nightlies? (Particularly as mentioned that the bump to 0.1.4 has fixed the VBR issues).

The bug fix branch is for "bug fixes". Changing from 0.1.1 to 0.1.4 fixes no known bugs in HandBrake. Enabling VBR fdk-aac would be a new feature and needs to be tested in the nighly builds for a while before it gets into *any* release.

[jacop89]

https://trac.handbrake.fr/changeset/7157



Great! Thanks for your work!!!

I have just one last question : when will be implemented in WinGUI version?

[moneymatt4life]

when s55 gets around to it thankfully, i've gotten a LOT better at using the cli

i forgot how much i disliked fdk's vbr compared to coreaudio either way, nice to finally be able to use it...
and i forgot that it's possible for av-aac to actually sound decent also its vbr ranges... 2 is ~320kpbs and that's the second lowest quality option?

[jacop89]

when s55 gets around to it thankfully, i've gotten a LOT better at using the cli

i forgot how much i disliked fdk's vbr compared to coreaudio either way, nice to finally be able to use it...
and i forgot that it's possible for av-aac to actually sound decent also its vbr ranges... 2 is ~320kpbs and that's the second lowest quality option?

s55..... Help us with WinGUI function!

[s55]

t's on my todo list, but it's not a priority.

Heck, I've not even got round to fixing the nasty bugs in the preview window yet, or finish of the underlying re-architecture, or the UI/UX updates .