PGS Subtitles from MKV cause crash on encode

[faustus]

I understand that support for Blu-Ray PGS subtitles is a relatively recent addition to HandBrake. Thanks for adding it, but I am having some difficulty making it work. Every time I try to transcode with PGS subtitles, HandBrake crashes. It seems to encode fine, until it reaches roughly the point in the file where it would encounter the first subtitle, then the process dumps core.

I am starting with a commercial Blu-Ray disc, and using MakeMKV to decrypt and change container formats (default options) to an .mkv file. The resulting .mkv file plays fine using VLC, and the display of subtitles can be turned on and off from the VLC interface perfectly. Using that .mkv file as input to HandBrake, however, any variation of including the subtitles I have tried results in the encode halting after ~0.3% (or roughly as soon as the subtitles start). By "any variation," I mean I have tried burning the subtitles into an .mp4 container, and also tried burning vs. passing them through to an .mkv. Any attempt to touch them results in the crash. If I have HandBrake ignore the subtitles, the encode completes smoothly; only attempting to include subtitles results in the crash.

This has happened to me with two disks so far, albeit mastered by the same folks--Criterion Collection versions of Yojimbo and Sanjuro (Japanese language). I'm afraid I'm new to Blu-Ray, and therefore don't have a large foreign language library to try encoding with, to see if the problem is peculiar to these disks.

I am running HandBrake 0.9.9 on Arch Linux. I can say the problem even persists accross GTK and CLI versions, and just for the heck of it, I uninstalled the pre-packaged HandBrake and built my own--but the problem is still there.

What follows is a sample of the output; removing anything having to do with -s or --subtitles* results in success (but without any subtitles, of course); thanks for any assistance or advice you may provide:

Code: Select all

 $ HandBrakeCLI -i /export/media/kevin/Yojimbo/Yojimbo_t00.mkv -o /export/media/kevin/Yojimbo/Yojimbo1080.mp4 -Z "High Profile" -g -s 1 -v
[10:31:14] hb_init: starting libhb thread
HandBrake rev5474 (2013061799) - Linux x86_64 - http://handbrake.fr
12 CPUs detected
Opening /export/media/kevin/Yojimbo/Yojimbo_t00.mkv...
[10:31:14] hb_scan: path=/export/media/kevin/Yojimbo/Yojimbo_t00.mkv, title_index=1
libbluray/bdnav/index_parse.c:162: indx_parse(): error opening /export/media/kevin/Yojimbo/Yojimbo_t00.mkv/BDMV/index.bdmv
libbluray/bdnav/index_parse.c:162: indx_parse(): error opening /export/media/kevin/Yojimbo/Yojimbo_t00.mkv/BDMV/BACKUP/index.bdmv
libbluray/bluray.c:2165: nav_get_title_list(/export/media/kevin/Yojimbo/Yojimbo_t00.mkv) failed
[10:31:14] bd: not a bd - trying as a stream/file instead
libdvdnav: Using dvdnav version 4.1.3
libdvdread: Using libdvdcss version 1.2.13 for DVD access
libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdnav:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.BUP failed
libdvdread: Can't open file VIDEO_TS.IFO.
libdvdnav: vm: failed to read VIDEO_TS.IFO
[10:31:14] dvd: not a dvd - trying as a stream/file instead
Input #0, matroska,webm, from '/export/media/kevin/Yojimbo/Yojimbo_t00.mkv':
  Metadata:
    title           : Yojimbo
    creation_time   : 2013-06-17 22:35:06
  Duration: 01:50:51.90, start: 0.000000, bitrate: 37663 kb/s
    Chapter #0.0: start 0.000000, end 355.813792
    Metadata:
      title           : Chapter 01
    Chapter #0.1: start 355.813792, end 979.770458
    Metadata:
      title           : Chapter 02
    Chapter #0.2: start 979.770458, end 1204.578375
    Metadata:
      title           : Chapter 03
    Chapter #0.3: start 1204.578375, end 1274.731792
    Metadata:
      title           : Chapter 04
    Chapter #0.4: start 1274.731792, end 1413.954208
    Metadata:
      title           : Chapter 05
    Chapter #0.5: start 1413.954208, end 1552.384167
    Metadata:
      title           : Chapter 06
    Chapter #0.6: start 1552.384167, end 1965.338375
    Metadata:
      title           : Chapter 07
    Chapter #0.7: start 1965.338375, end 2339.253583
    Metadata:
      title           : Chapter 08
    Chapter #0.8: start 2339.253583, end 2558.138917
    Metadata:
      title           : Chapter 09
    Chapter #0.9: start 2558.138917, end 2791.038250
    Metadata:
      title           : Chapter 10
    Chapter #0.10: start 2791.038250, end 2975.973000
    Metadata:
      title           : Chapter 11
    Chapter #0.11: start 2975.973000, end 3077.657917
    Metadata:
      title           : Chapter 12
    Chapter #0.12: start 3077.657917, end 3365.195167
    Metadata:
      title           : Chapter 13
    Chapter #0.13: start 3365.195167, end 3559.264042
    Metadata:
      title           : Chapter 14
    Chapter #0.14: start 3559.264042, end 3799.670875
    Metadata:
      title           : Chapter 15
    Chapter #0.15: start 3799.670875, end 3922.209958
    Metadata:
      title           : Chapter 16
    Chapter #0.16: start 3922.209958, end 4039.785750
    Metadata:
      title           : Chapter 17
    Chapter #0.17: start 4039.785750, end 4325.112458
    Metadata:
      title           : Chapter 18
    Chapter #0.18: start 4325.112458, end 4429.466708
    Metadata:
      title           : Chapter 19
    Chapter #0.19: start 4429.466708, end 4727.639583
    Metadata:
      title           : Chapter 20
    Chapter #0.20: start 4727.639583, end 5004.582917
    Metadata:
      title           : Chapter 21
    Chapter #0.21: start 5004.582917, end 5546.290750
    Metadata:
      title           : Chapter 22
    Chapter #0.22: start 5546.290750, end 5890.175958
    Metadata:
      title           : Chapter 23
    Chapter #0.23: start 5890.175958, end 5999.618625
    Metadata:
      title           : Chapter 24
    Chapter #0.24: start 5999.618625, end 6084.995583
    Metadata:
      title           : Chapter 25
    Chapter #0.25: start 6084.995583, end 6651.895250
    Metadata:
      title           : Chapter 26
    Stream #0:0(eng): Video: h264 (High), yuv420p, 1920x1080 [SAR 1:1 DAR 16:9], 23.98 fps, 23.98 tbr, 1k tbn, 47.95 tbc
    Stream #0:1(jpn): Audio: dts (DTS), 48000 Hz, 3.0, fltp, 1536 kb/s (default)
    Metadata:
      title           : 3/0
    Stream #0:2(eng): Audio: pcm_s24le, 48000 Hz, 1 channels, s32, 1152 kb/s
    Metadata:
      title           : 1/0
    Stream #0:3(eng): Subtitle: hdmv_pgs_subtitle
[10:31:14] scan: decoding previews for title 1
[10:31:14] scan: audio 0x1: dca, rate=48000Hz, bitrate=1536000 Japanese (DTS) (3.0 ch)
[10:31:14] scan: audio 0x2: pcm_s24le, rate=48000Hz, bitrate=1152000 English (pcm_s24le) (1.0 ch)
Scanning title 1 of 1, preview 10, 100.00 %[10:31:24] scan: 10 previews, 1920x1080, 23.976 fps, autocrop = 132/132/0/0, aspect 16:9, PAR 1:1
Scanning title 1 of 1, preview 10, 100.00 %[10:31:24] libhb: scan thread found 1 valid title(s)
+ title 1:
  + stream: /export/media/kevin/Yojimbo/Yojimbo_t00.mkv
  + duration: 01:50:51
  + size: 1920x1080, pixel aspect: 1/1, display aspect: 1.78, 23.976 fps
  + autocrop: 132/132/0/0
  + chapters:
    + 1: cells 0->0, 0 blocks, duration 00:05:56
    + 2: cells 0->0, 0 blocks, duration 00:10:24
    + 3: cells 0->0, 0 blocks, duration 00:03:45
    + 4: cells 0->0, 0 blocks, duration 00:01:10
    + 5: cells 0->0, 0 blocks, duration 00:02:19
    + 6: cells 0->0, 0 blocks, duration 00:02:18
    + 7: cells 0->0, 0 blocks, duration 00:06:53
    + 8: cells 0->0, 0 blocks, duration 00:06:14
    + 9: cells 0->0, 0 blocks, duration 00:03:39
    + 10: cells 0->0, 0 blocks, duration 00:03:53
    + 11: cells 0->0, 0 blocks, duration 00:03:05
    + 12: cells 0->0, 0 blocks, duration 00:01:42
    + 13: cells 0->0, 0 blocks, duration 00:04:48
    + 14: cells 0->0, 0 blocks, duration 00:03:14
    + 15: cells 0->0, 0 blocks, duration 00:04:00
    + 16: cells 0->0, 0 blocks, duration 00:02:03
    + 17: cells 0->0, 0 blocks, duration 00:01:58
    + 18: cells 0->0, 0 blocks, duration 00:04:45
    + 19: cells 0->0, 0 blocks, duration 00:01:44
    + 20: cells 0->0, 0 blocks, duration 00:04:58
    + 21: cells 0->0, 0 blocks, duration 00:04:37
    + 22: cells 0->0, 0 blocks, duration 00:09:02
    + 23: cells 0->0, 0 blocks, duration 00:05:44
    + 24: cells 0->0, 0 blocks, duration 00:01:49
    + 25: cells 0->0, 0 blocks, duration 00:01:25
    + 26: cells 0->0, 0 blocks, duration 00:09:27
  + audio tracks:
    + 1, Japanese (DTS) (3.0 ch) (iso639-2: jpn), 48000Hz, 1536000bps
    + 2, English (pcm_s24le) (1.0 ch) (iso639-2: eng)
  + subtitle tracks:
    + 1, English (iso639-2: eng) (Bitmap)(PGS)
+ Using preset: High Profile
AC3 Passthru requested and input codec is not AC3 for track 2, using AC3 encoder
[10:31:24] 1 job(s) to process
[10:31:24] starting job
[10:31:24] yadif thread started for segment 0
[10:31:24] yadif thread started for segment 3
[10:31:24] yadif thread started for segment 5
[10:31:24] yadif thread started for segment 6
[10:31:24] yadif thread started for segment 1
[10:31:24] yadif thread started for segment 2
[10:31:24] yadif thread started for segment 8
[10:31:24] decomb filter thread started for segment 4
[10:31:24] decomb filter thread started for segment 10
[10:31:24] decomb filter thread started for segment 11
[10:31:24] yadif thread started for segment 10
[10:31:24] decomb check thread started for segment 3
[10:31:24] decomb check thread started for segment 5
[10:31:24] decomb filter thread started for segment 1
[10:31:24] decomb check thread started for segment 9
[10:31:24] decomb check thread started for segment 10
[10:31:24] mask filter thread started for segment 0
[10:31:24] yadif thread started for segment 7
[10:31:24] decomb filter thread started for segment 5
[10:31:24] mask filter thread started for segment 5
[10:31:24] decomb filter thread started for segment 7
[10:31:24] yadif thread started for segment 4
[10:31:24] decomb filter thread started for segment 8
[10:31:24] decomb filter thread started for segment 9
[10:31:24] decomb check thread started for segment 1
[10:31:24] yadif thread started for segment 9
[10:31:24] decomb check thread started for segment 0
[10:31:24] decomb check thread started for segment 2
[10:31:24] decomb check thread started for segment 4
[10:31:24] yadif thread started for segment 11
[10:31:24] mask erode thread started for segment 7
[10:31:24] mask erode thread started for segment 8
[10:31:24] decomb check thread started for segment 6
[10:31:24] decomb check thread started for segment 7
[10:31:24] decomb check thread started for segment 8
[10:31:24] decomb filter thread started for segment 2
[10:31:24] decomb check thread started for segment 11
[10:31:24] decomb filter thread started for segment 3
[10:31:24] mask filter thread started for segment 1
[10:31:24] mask filter thread started for segment 2
[10:31:24] mask dilate thread started for segment 5
[10:31:24] mask dilate thread started for segment 7
[10:31:24] decomb filter thread started for segment 6
[10:31:24] mask filter thread started for segment 7
[10:31:24] mask filter thread started for segment 6
[10:31:24] mask filter thread started for segment 8
[10:31:24] mask filter thread started for segment 9
[10:31:24] mask filter thread started for segment 10
[10:31:24] work: sanitizing track 1 mixdown Dolby Pro Logic II to Stereo
[10:31:24] mask erode thread started for segment 0
[10:31:24] mask erode thread started for segment 1
[10:31:24] mask erode thread started for segment 2
[10:31:24] mask erode thread started for segment 3
[10:31:24] mask erode thread started for segment 5
[10:31:24] mask erode thread started for segment 6
[10:31:24] mask erode thread started for segment 4
[10:31:24] decomb filter thread started for segment 0
[10:31:24] mask erode thread started for segment 9
[10:31:24] mask erode thread started for segment 10
[10:31:24] mask erode thread started for segment 11
[10:31:24] mask dilate thread started for segment 0
[10:31:24] mask dilate thread started for segment 1
[10:31:24] mask dilate thread started for segment 2
[10:31:24] mask dilate thread started for segment 3
[10:31:24] mask dilate thread started for segment 4
[10:31:24] mask filter thread started for segment 3
[10:31:24] mask dilate thread started for segment 6
[10:31:24] mask filter thread started for segment 4
[10:31:24] mask dilate thread started for segment 8
[10:31:24] mask dilate thread started for segment 9
[10:31:24] mask dilate thread started for segment 10
[10:31:24] mask dilate thread started for segment 11
[10:31:24] mask filter thread started for segment 11
[10:31:24] sync: expecting 159485 video frames
[10:31:24] job configuration:
[10:31:24]  * source
[10:31:24]    + /export/media/kevin/Yojimbo/Yojimbo_t00.mkv
[10:31:24]    + title 1, chapter(s) 1 to 26
[10:31:24]    + container: matroska,webm
[10:31:24]    + data rate: 37663 kbps
[10:31:24]  * destination
[10:31:24]    + /export/media/kevin/Yojimbo/Yojimbo1080.mp4
[10:31:24]    + container: MPEG-4 (.mp4 and .m4v)
[10:31:24]      + 64-bit formatting
[10:31:24]      + chapter markers
[10:31:24]  * video track
[10:31:24]    + decoder: h264
[10:31:24]    + frame rate: same as source (around 23.976 fps)
[10:31:24]    + filters
[10:31:24]      + Decomb (default settings)
[10:31:24]      + Framerate Shaper (0:27000000:1126125)
[10:31:24]        + frame rate: same as source (around 23.976 fps)
[10:31:24]      + Subtitle renderer (132:132:0:0)
[10:31:24]      + Crop and Scale (1920:816:132:132:0:0)
[10:31:24]        + source: 1920 * 1080, crop (132/132/0/0): 1920 * 816, scale: 1920 * 816
[10:31:24]    + loose anamorphic
[10:31:24]      + storage dimensions: 1920 * 816, mod 2
[10:31:24]      + pixel aspect ratio: 1 / 1
[10:31:24]      + display dimensions: 1920 * 816
[10:31:24]    + grayscale mode
[10:31:24]    + encoder: H.264 (x264)
[10:31:24]      + x264 preset: medium
[10:31:24]      + h264 profile: high
[10:31:24]      + h264 level: 4.1
[10:31:24]      + quality: 20.00 (RF)
[10:31:24]  * subtitle track 1, English (track 3, id 0x3) Picture [PGS] -> Render/Burn-in
[10:31:24]  * audio track 1
[10:31:24]    + decoder: Japanese (DTS) (3.0 ch) (track 1, id 0x1)
[10:31:24]      + bitrate: 1536 kbps, samplerate: 48000 Hz
[10:31:24]    + mixdown: Stereo
[10:31:24]    + encoder: AAC (faac)
[10:31:24]      + bitrate: 160 kbps, samplerate: 48000 Hz
[10:31:24]  * audio track 2
[10:31:24]    + decoder: Japanese (DTS) (3.0 ch) (track 1, id 0x1)
[10:31:24]      + bitrate: 1536 kbps, samplerate: 48000 Hz
[10:31:24]    + mixdown: 5.1 Channels
[10:31:24]    + encoder: AC3 (ffmpeg)
[10:31:24]      + bitrate: 640 kbps, samplerate: 48000 Hz
[10:31:24] reader: first SCR 0 id 0x0 DTS 0
[10:31:24] encx264: min-keyint: 24, keyint: 240
[10:31:24] encx264: encoding with stored aspect 1/1
[10:31:24] encx264: Encoding at constant RF 20.000000
x264 [warning]: --psnr used with psy on: results will be invalid!
x264 [warning]: --tune psnr should be used if attempting to benchmark psnr!
x264 [info]: using SAR=1/1
x264 [info]: using cpu capabilities: MMX2 SSE2Fast SSSE3 FastShuffle SSE4.2 AVX
x264 [info]: profile High, level 4.1
Encoding: task 1 of 1, 0.31 % (39.60 fps, avg 49.32 fps, ETA 00h53m45s)Segmentation fault (core dumped) 

[JohnAStebbins]

Can you use gdb to create a backtrace? First, rebuild with debug enabled (configure --debug=std --optimize=none).
After the build is complete, from the build directory, you can run it in gdb like this:

Code: Select all

$ gdb HandBrakeCLI
(gdb) run -i /export/media/kevin/Yojimbo/Yojimbo_t00.mkv -o /export/media/kevin/Yojimbo/Yojimbo1080.mp4 -Z "High Profile" -g -s 1 -v

After it segfaults, use the "bt" command to generate a backtrace. That should show us exactly where the problem is.

[faustus]

Thank you for your outrageously rapid reply!

Here is the tail of the gdb output (segfault and backtrace):

Code: Select all

Encoding: task 1 of 1, 0.31 % (39.66 fps, avg 49.53 fps, ETA 00h53m30s)
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffe917f2700 (LWP 21077)]
0x00007ffff7170d8f in avcodec_decode_subtitle2 () from /usr/lib/libavcodec.so.54
(gdb) bt
#0  0x00007ffff7170d8f in avcodec_decode_subtitle2 () from /usr/lib/libavcodec.so.54
#1  0x000000000042b34f in ?? ()
#2  0x00000000004175d2 in ?? ()
#3  0x000000000042069b in ?? ()
#4  0x00007ffff4cecdd2 in start_thread () from /usr/lib/libpthread.so.0
#5  0x00007ffff4001cdd in clone () from /usr/lib/libc.so.6

[JohnAStebbins]

It appears like you did not rebuild with debug info enabled. There should be more information in the backtrace (like line numbers).

[faustus]

I did rebuild it, but was not running from within the build directory. Didn't think it should make a difference (having replaced the previously installed version), but apparently it does. I have more output now (complete with line numbers)...

Code: Select all

Encoding: task 1 of 1, 0.32 % (47.76 fps, avg 51.37 fps, ETA 00h51m34s)
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7ffe917f2700 (LWP 7496)]
0x00007ffff7170d8f in avcodec_decode_subtitle2 () from /usr/lib/libavcodec.so.54
(gdb) bt
#0  0x00007ffff7170d8f in avcodec_decode_subtitle2 () from /usr/lib/libavcodec.so.54
#1  0x000000000042b34f in decsubWork (w=0x7fffe00f1ed0, buf_in=<optimized out>, 
    buf_out=0x7ffe917f1ef8) at ../libhb/decpgssub.c:207
#2  0x00000000004175d2 in work_loop (_w=0x7fffe00f1ed0) at ../libhb/work.c:1505
#3  0x000000000042069b in hb_thread_func (_t=0x7fffe0a47810) at ../libhb/ports.c:369
#4  0x00007ffff4cecdd2 in start_thread () from /usr/lib/libpthread.so.0
#5  0x00007ffff4001cdd in clone () from /usr/lib/libc.so.6

[JohnAStebbins]

something is still not built right. There should be a line number for avcodec_decode_subtitle2. e.g. it should look something like this:

Code: Select all

(gdb) bt
#0  avcodec_decode_subtitle2 (avctx=0x7fffcc0f96c0, sub=0x7fffc27fbab0, 
    got_sub_ptr=0x7fffc27fba4c, avpkt=0x7fffc27fba50)
    at libavcodec/utils.c:1410
#1  0x000000000046c0b7 in decsubWork (w=0x7fffcc0020c0, buf_in=0x7fffc27fbb90, 
    buf_out=0x7fffc27fbb88) at ../libhb/decpgssub.c:207
#2  0x00000000004a47bb in work_loop (_w=0x7fffcc0020c0) at ../libhb/work.c:1450
#3  0x000000000046cd88 in hb_thread_func (_t=0x7fffcc00b500)
    at ../libhb/ports.c:404
#4  0x000000358aa07d15 in start_thread () from /lib64/libpthread.so.0
#5  0x000000358a2f248d in clone () from /lib64/libc.so.6

Did you configure and rebuild over the top of a previous build? There are special steps required to clean the contrib libraries. e.g. "make ffmpeg.xclean" will force a rebuild of the libav libraries.

[faustus]

Sorry it has taken me a few days to respond, but your last post put me on the track of something that has ultimately identified my problem.

As I mentioned, I first ran into the subtitles problem using the HandBrake available in the official Arch Linux repos. In my subsequent attempts to recompile HB, I was using the build script in the ABS (Arch Build System, similar to BSD ports, Gentoo Portage, et al). I modified the script to add debug support, etc, but did not pay enough attention to the rest of it. Therein lies the crux of the matter...

The HandBrake PKGBUILD in ABS builds it against some shared library dependencies (most pertinently, ffmpeg), also installed from Arch repos, whereas the typical HandBrake make procedure downloads and installs its own, somewhat patched, ffmpeg. Specifically, the Arch PKGBUILD includes these lines:

Code: Select all

# Use more system libs
  sed -i \
    -e '/MODULES += contrib\/libbluray/d' \
    -e '/MODULES += contrib\/ffmpeg/d' \
    -e '/MODULES += contrib\/x264/d' \
    make/include/main.defs

If I delete the ffmpeg modification from the PKGBUILD, then compiling using ABS results in a HandBrake which does not choke on subtitles!

To make a long story short, I believe the problem is in the version of libavcodec installed by Arch's ffmpeg package, versus the static ffmpeg which HandBrake's default upstream configuration depends upon. That being the case, this bug should really be passed to the appropriate Arch package maintainer(s).

Thanks for your help. If nothing else, I now have a build of HandBrake which can work with PGS subtitles.

[JohnAStebbins]

Yup, that's exactly the reason we don't allow substitution of certain libraries in our build system. libav (aka ffmpeg) is a rapidly changing library that we apply local patches to for bug fixes and feature enhancements. Distributions that do what Arch has done are patching HandBrakes build system to do so. Typically they don't even bother to drop by and ask whether that would be a good idea or not.

[Deleted User 11865]

We can't stop people from trying to build against system libs, but at some point I think we should try and add some code to check whether the Libav version used is recent enough and if not, crash outright