[Fixed] Nightly cores with one video (MPEG sequence, v2)

[rklm]

Please describe the problem in as much detail as possible:
Handbrake cores when opening one specific video file regardless of whether via command line option or via "open".

What are the steps to reproduce this problem:
Just open this file (2GB) with ghb.

What version of HandBrake you are running:
20160701184647-b1a4f0d-master (x86_64)

What operating system and version and you running (e.g. OSX 10.11, Windows 7, Ubuntu 14):

Code: Select all

$ uname -a
Linux babelfish 4.2.0-41-generic #48-Ubuntu SMP Fri Jun 24 11:28:43 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
$ lsb_release -a
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 15.10
Release:	15.10
Codename:	wily

All packages current.

If there was any exception or error displayed, please copy it and paste it here:

Code: Select all

$ ghb Videos/Cut/Verdacht\ -\ 3sat\ -\ So\ 03\ Jul\ 2016\ 23_25_00\ CEST.mpg 
Segmentation fault

Please include the scan or encode log:

no log, obviously

[video.baba]

cores? Do you mean "crashes"?

[mduell]

No, he means core dumps.

[rklm]

No, he means core dumps.

Yes, exactly. Sorry for my sloppily phrased subject.

[rklm]

20160705184049-7745f42-master (x86_64) shows the same behavior and produces a core dump.

[Deleted User 11865]

The sample is a bit large, if you have anything smaller that reproduces the crash, it would be welcome.

Also, our MPEG demuxer expert is busy and most likely won't be back until next week, so don't expect an overnight fix

[rklm]

The sample is a bit large, if you have anything smaller that reproduces the crash, it would be welcome.

I can try to find a smaller one but I cannot promise that I will get around to this before July 16th.

Also, our MPEG demuxer expert is busy and most likely won't be back until next week, so don't expect an overnight fix

OK, thank you for the notice. That seems to fit my schedule well.

[rklm]

Also, our MPEG demuxer expert is busy and most likely won't be back until next week, so don't expect an overnight fix

One more observation: the segfault also happens when reading a DVD, and it happens at the end of scanning as far as I can observe from the progress bar. So maybe it is not even related to the format of the input.

I uploaded also a small sample (57MB). If it helps this is a recording made with "me tv" and cut with "DVBCut". Is there anything else I can provide?

[Deleted User 11865]

Maybe try tomorrow's nightly? There's a fix that may apply to your crash.

[rklm]

Maybe try tomorrow's nightly? There's a fix that may apply to your crash.

No core during loading. Encoding looks good so far as well. I think you nailed it! Thanks a bunch!