[Fixed] Subtitle Presets
Forum rules
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.
*******************************
*******************************
Please be aware we are now using GitHub for issue tracking and feature requests.
- This section of the forum is now closed to new topics.
*******************************
[Fixed] Subtitle Presets
The latest build doesn't load the subtitle track selection behavior preset correctly. I looked in the C# code and the line to load that item is commented out ("JsonPresetFactory.cs", line# 362).
Thanks.
Thanks.
Re: Subtitle Presets
I'm not a C# guy, but I replaced the commented out line with:
and it seems to work.
Thanks.
Code: Select all
preset.SubtitleTrackBehaviours.SelectedBehaviour = EnumHelper<SubtitleBehaviourModes>.GetValue(importedPreset.SubtitleTrackSelectionBehavior);
Thanks.
Re: Subtitle Presets
Cool. I'll try fix are the weekend if I have time.
p.s If you find a bug, better posting in the bugs forum as I don't always follow every discussion on the windows forum.
Moving to bugs.
p.s If you find a bug, better posting in the bugs forum as I don't always follow every discussion on the windows forum.
Moving to bugs.
Re: Subtitle Presets
OK, sorry. I will do so next time.
Re: [Fixed] Subtitle Presets
Fixed: https://github.com/HandBrake/HandBrake/ ... 65490c172f
Couple of other things in there I will need to tidy up in there with Audio and other options, but I'll sort that when i get back home.
Couple of other things in there I will need to tidy up in there with Audio and other options, but I'll sort that when i get back home.
-
- Novice
- Posts: 63
- Joined: Wed Dec 17, 2014 11:19 am
Re: [Fixed] Subtitle Presets
there's so many things wrong with the preset system. I'm waiting for it to finish the moving process from "user_presets.json", then I report all the bugs i've found.
Re: [Fixed] Subtitle Presets
Thank you, s55!
Re: [Fixed] Subtitle Presets
Is there still problems with the preset system, or is all taken care of?
Re: [Fixed] Subtitle Presets
I'm not actively working on anything presets right now so if there are issues, please report them.
Re: [Fixed] Subtitle Presets
I am not seeing any issues with the presets.
Re: [Fixed] Subtitle Presets
Windows 64bit, nightly, 7f39ee6.
With regard to user presets, the following aren't currently saving or loading properly between program restarts.
Eg. Anything you set up and save as an existing or new user-preset doesn't work when the program is restarted.
MKV/MP4 container type
Subtitle defaults
With regard to user presets, the following aren't currently saving or loading properly between program restarts.
Eg. Anything you set up and save as an existing or new user-preset doesn't work when the program is restarted.
MKV/MP4 container type
Subtitle defaults
Re: [Fixed] Subtitle Presets
Found the Container issue. Fixed in https://github.com/HandBrake/HandBrake/ ... 3ec0f2b8ac
Don't see the subtitle defaults one though. It seems tor reload them correctly. (bar a small issue with the "(any)" language)
Don't see the subtitle defaults one though. It seems tor reload them correctly. (bar a small issue with the "(any)" language)
Re: [Fixed] Subtitle Presets
p.s if you find new issues, please raise a new thread since this one is marked as closed.