[Fixed] nlmeans tunes cli-svn7333

[moneymatt4life]

either i don't know how to work nlmeans from the cli , or something isn't working right using no tune works though...
cli

Code: Select all

C:\Users\Mathew>handbrake\handbrakecli.exe -i "D:\MakeMKV\Perfume - Cling Cling.mkv" -o "D:\Videos\Handbrake\Perfume - Cling Cling.m4v" -q 18 --encoder-preset=veryslow --encoder-level=3.0 --encoder-profile=high -x threads=4:aq-mode=3 -Q 5 --nlmeans=medium --nlmeans-tune=film 2> "D:\Videos\Handbrake\log.txt"

Code: Select all

[17:11:27] hb_init: starting libhb thread
[17:11:27] thread 6e683e0 started ("libhb")
HandBrake svn7333 (2015063001) - MinGW x86_64 - https://handbrake.fr
4 CPUs detected
Opening D:\MakeMKV\Perfume - Cling Cling.mkv...
[17:11:27] CPU: Intel(R) Core(TM) i3-2330M CPU @ 2.20GHz
[17:11:27]  - Intel microarchitecture Sandy Bridge
[17:11:27]  - logical processor count: 4
[17:11:27] Intel Quick Sync Video support: yes
[17:11:27]  - Intel Media SDK hardware: API 1.4 (minimum: 1.3)
[17:11:27]  - H.264 encoder: yes
[17:11:27]     - preferred implementation: hardware (any)
[17:11:27]     - capabilities (hardware):  vsinfo opt1
[17:11:27] hb_scan: path=D:\MakeMKV\Perfume - Cling Cling.mkv, title_index=1
udfread ERROR: ECMA 167 Volume Recognition failed
src/libbluray/disc/disc.c:251: failed opening UDF image D:\MakeMKV\Perfume - Cling Cling.mkv
src/libbluray/disc/disc.c:332: error opening file BDMV\index.bdmv
src/libbluray/disc/disc.c:332: error opening file BDMV\BACKUP\index.bdmv
[17:11:27] bd: not a bd - trying as a stream/file instead
libdvdnav: Using dvdnav version 5.0.1
libdvdread: Encrypted DVD support unavailable.
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdread:DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.BUP failed
libdvdread: Can't open file VIDEO_TS.IFO.
libdvdnav: vm: failed to read VIDEO_TS.IFO
[17:11:27] dvd: not a dvd - trying as a stream/file instead
Input #0, matroska,webm, from 'D:\MakeMKV\Perfume - Cling Cling.mkv':
  Duration: 00:04:39.74, start: 0.000000, bitrate: N/A
    Stream #0.0(jpn): Video: mpeg2video (Main), yuv420p, 720x480 [PAR 32:27 DAR 16:9], 9800 kb/s, PAR 186:157 DAR 279:157, 29.97 fps, 1k tbn, 59.94 tbc
    Stream #0.1(jpn): Audio: flac, 48000 Hz, stereo, s16 (default)
[17:11:27] scan: decoding previews for title 1
[17:11:27] scan: audio 0x1: flac, rate=48000Hz, bitrate=1 Japanese (FLAC) (2.0 ch)

Scanning title 1 of 1, preview 3, 30.00 %
Scanning title 1 of 1, preview 7, 70.00 %
Scanning title 1 of 1, preview 10, 100.00 %[17:11:27] scan: 10 previews, 720x480, 23.976 fps, autocrop = 0/0/2/2, aspect 16:9, PAR 32:27
[17:11:27] scan: supported video decoders: avcodec dxva2
[17:11:27] libhb: scan thread found 1 valid title(s)
+ Using preset: Normal
+ title 1:
  + stream: D:\MakeMKV\Perfume - Cling Cling.mkv
  + duration: 00:04:39
  + size: 720x480, pixel aspect: 32/27, display aspect: 1.78, 23.976 fps
  + autocrop: 0/0/2/2
  + support opencl: no
  + chapters:
    + 1: cells 0->0, 0 blocks, duration 00:04:39
  + audio tracks:
    + 1, Japanese (FLAC) (2.0 ch) (iso639-2: jpn)
  + subtitle tracks:
Custom nlmeans parameters specified; ignoring nlmeans tune (none).
ERROR: Invalid denoise filter settings (film,none)
Failed to initialize job
HandBrake has exited.

[CitizenInsomniac]

I am able to repro the same issue with both 10.2 stable as well as the latest nightly build. It would appear that --nlmeans-tune is not being parsed correctly.

[BradleyS]

What happens when you quote the values, e.g. --nlmeans="medium" --nlmeans-tune="film" ?

What about only using --nlmeans with no value?

[JohnAStebbins]

Works fine for me in 0.10.2.

Fixed in svn. Should be available in the next nightly build
http://trac.handbrake.fr/changeset/7398

Correct usage is "--nlmeans=medium --nlmeans-tune film" or "--nlmeans=medium --nlmeans-tune=film". Optional parameters require the '=' separator. Required parameters may be expressed with or without '='. When in doubt, use the '='.

[moneymatt4life]

i can't remember if i tested in 0.10.2 i think one is supposed to, but oh well
either way, the cli input i used above is working now

[CitizenInsomniac]

Correct usage is "--nlmeans=medium --nlmeans-tune film" or "--nlmeans=medium --nlmeans-tune=film". Optional parameters require the '=' separator. Required parameters may be expressed with or without '='. When in doubt, use the '='.

Ahhh... It'd be very useful if "handbrakecli --help" mentioned that.

[JohnAStebbins]

Ahhh... It'd be very useful if "handbrakecli --help" mentioned that.

There are dozens of options that require the same treatment and the semantics of optional arguments is the same for every program. The --help output is already exceedingly long, so repeating

Optional parameters require the '=' separator. Required parameters may be expressed with or without '='. When in doubt, use the '='.

everywhere would make it significantly longer and probably obscure the more important information about what the options do.

We could probably be more clear and consistent about which options take optional arguments in a way that doesn't increase the help output volume. But repeating how optional arguments work shouldn't be necessary for someone familiar with using the command line since all programs work this way.