Error in frmqueue.cs

HandBrake for Windows support
Forum rules
An Activity Log is required for support requests. Please read How-to get an activity log? for details on how and why this should be provided.
Post Reply
ordovice
Posts: 15
Joined: Mon Jul 23, 2007 7:05 pm

Error in frmqueue.cs

Post by ordovice »

Not a major one though (not one that affects functionality)

in setEncValue

Code: Select all

else
                {
                    chatpers = parsed.DVDChapterStart.ToString();
                    if (parsed.DVDChapterFinish != 0)
                        chatpers = chatpers + " - " + parsed.DVDChapterFinish;
                    lbl_chapt.Text = parsed.DVDChapterStart + chatpers;
                }

I believe lbl_chapt.Text should just be chatpers, based on how this is written (and alsojust curious, why the typo of chatpers all the way through)

Great program. I've been keeping up with the SVNs since 2.4 came out, and it keeps improving.

Thanks for your work, sr55 and crew.

-Dan
User avatar
s55
HandBrake Team
Posts: 9912
Joined: Sun Dec 24, 2006 1:05 pm

Post by s55 »

I believe lbl_chapt.Text should just be chatpers, based on how this is written
You are indeed correct. Thanks for letting me know.
(and alsojust curious, why the typo of chatpers all the way through)
Copy and Paste.


All fixed in 1089
ordovice
Posts: 15
Joined: Mon Jul 23, 2007 7:05 pm

Post by ordovice »

Another thing to look at for the next revision is the new threading mechanism ... it works great spawning the new process, but it's not setting the priority of the spawned process correctly ..

I wondered why the heck my computer was bogging down on encodes, until I finally checked it tonight ..
:-)
-Dan
User avatar
s55
HandBrake Team
Posts: 9912
Joined: Sun Dec 24, 2006 1:05 pm

Post by s55 »

Thank you.

Keep em coming :)

Fixed in 1092. It appears I accidentally removed the code in Functions/CLI.cs
ordovice
Posts: 15
Joined: Mon Jul 23, 2007 7:05 pm

Post by ordovice »

Another one, (don't know if you've caught it already), in the query parser,when encoding a single chapter movie, the parser can't handle the lack of a second chapter ...

Thanks again for everything.
User avatar
s55
HandBrake Team
Posts: 9912
Joined: Sun Dec 24, 2006 1:05 pm

Post by s55 »

Fixed in 1095.

Thanks :)
Post Reply