Search found 94 matches

by Cyander
Wed Apr 25, 2007 2:14 pm
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

I think there is something very odd about that crash, and I am surprised you didn't see it too: EXC_BREAKPOINT. (nevermind... Apple is intentionally throwing this exception for debuggers... durrrrrr) That said... I am seeing it too... and wondering why. This didn't happen until I sync'd to 545. EDIT...
by Cyander
Tue Apr 24, 2007 5:45 am
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

Figured it out... wrong filename on the server, try again.
by Cyander
Mon Apr 23, 2007 6:52 pm
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

That is very unsual, I will look into it... I explicitly svn updated to 545, and resolving test.c by hand before making the diff. The test.c diff in particular shrunk by a ton because of 545 and my version both using the same sort of line breaks. It should be a single diff "Final.diff"... ...
by Cyander
Mon Apr 23, 2007 2:08 am
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

I have posted up the diff (see the URL in the first post).

The CLI and library are synced up to about 10 minutes ago.

The NIB still needs to be hand-merged, unfortunately. Curse Apple and its use of binary NIBs for the serialized objects. :/
by Cyander
Sat Apr 21, 2007 6:01 pm
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

jbrjake wrote:Okay, Cyander.

0.8.5b1 is out, which means it's your time now =)

I'll need a diff against a current revision.
I'll work on that sometime this weekend... have some other engagements I already agreed to, but I should be able to find an hour or two to re-diff and resolve any issues.
by Cyander
Wed Apr 18, 2007 7:03 am
Forum: Development
Topic: Subtitle Overlay Improvements
Replies: 13
Views: 6078

The problem I have with yellow is that there is too much contrast. You have this thick black border, filled with bright-as-the-sun yellow. I find my eyes hurting more with yellow subtitles on a 40" TV than I do white. Especially when viewing in theater-like conditions. Of course, I am also the ...
by Cyander
Mon Apr 09, 2007 10:16 pm
Forum: Feature Requests
Topic: Subitles that can be turned On/Off
Replies: 43
Views: 19590

The big problem with automatic ripping to any text-based format (which I personally prefer) would not work that well, and introduce a horrific amount of complexity to Handbrake. OCR technology in open software is far too immature to do the job in any satisfactory manner. I tried doing an actual work...
by Cyander
Mon Apr 09, 2007 2:48 pm
Forum: Development
Topic: Subtitle Overlay Improvements
Replies: 13
Views: 6078

I have plenty of sample DVDs. I have a fair amount of subtitled movies and TV series sitting around that I can hit most of the needs. But really, the lack of chroma information being sampled is the one reason why they can't do multi-color titles, and are translucent. The work I am about ready to sta...
by Cyander
Wed Apr 04, 2007 9:33 pm
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

Well, it is always good to verify with a second app sometimes when debugging (and I do). ;) I think I might be unclear though. DVDs are authored in 'cells', not 'frames'. So a chapter break is aligned to a cell, and the cell's first frame is right there, but you have no way of knowing if that first ...
by Cyander
Wed Apr 04, 2007 12:02 am
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

The closest thing to perfection is to imitate the logic of the DVD player. The problem with doing this is that DVDs are authored in a such a way to depend on complicated logic to make sure that the right frame is the one used for the chapter entry. So what I was seeing was the following: Cell 1 |Cel...
by Cyander
Tue Apr 03, 2007 11:48 pm
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

I know of the issues with chapter sync, and have improved it even further. There are some oddities with how mpeg2dec handles GOPs near chapter breaks, and passes that state back. I have addressed some of these issues, and also addressed an issue where if the last chapter only had one cell... the las...
by Cyander
Tue Apr 03, 2007 11:42 pm
Forum: Feature Requests
Topic: Chapters inside MP4 file
Replies: 93
Views: 49662

User editable chapter names would be gravy. I'll be so excited when I rip my first DVDs with chapter marks and see those chapters on my iPod. I have a build that does reliably let the user edit chapter marks (and the support for frame-accurate sync has improved from the diff I showed to the dev tea...
by Cyander
Thu Mar 29, 2007 7:10 am
Forum: Development
Topic: Chapter Sync and Chapter Name Fixes/Support
Replies: 81
Views: 19705

Chapter Sync and Chapter Name Fixes/Support

Okay, I finally have something ready to show. The patch is a bit large, so I am having to link to it rather than just drop it in. http://homepage.mac.com/cyander/Files/ChapterWork.zip It includes 3 diffs (one against libhb, one against the CLI, one against the OS X UI), and MainMenu.nib. MainMenu.ni...
by Cyander
Wed Mar 28, 2007 9:47 pm
Forum: Feature Requests
Topic: Chapters inside MP4 file
Replies: 93
Views: 49662

Bump. :P Okay, I think this thing is about ready to let the HB team look it over and decide if they want to accept/deny the patch. I ran about as close to a test suite as I can run on a Mac Pro with 2 drives, and in 8 hours. No more bugs/errors when compared to DVD Player or a standalone box. I'll b...
by Cyander
Tue Mar 27, 2007 3:34 pm
Forum: Feature Requests
Topic: Chapters inside MP4 file
Replies: 93
Views: 49662

A pair of bugs in some older code which tries to calculate the chapter from the current 'cell' in the DVD is what seems to be preventing my sync method from working. In HB code? Where? You're not talking about sync.c, are you? Nah... the bugs are in dvd.c. Ironically, fixing them has /zero/ effect ...
by Cyander
Tue Mar 27, 2007 11:16 am
Forum: Development
Topic: 5.1 Audio and iTunes Tagging
Replies: 8
Views: 4832

I actually saw this myself, and have filed a bug against iTunes on this. Apple has asked for a couple samples to demonstrate the bug, which I supplied. I haven't gotten a response back quite yet, but I personally believe it is an iTunes bug (because Quicktime sees the tags just fine, AND I can repli...
by Cyander
Tue Mar 27, 2007 11:13 am
Forum: Devices and Presets
Topic: Can Chapters Be Added to M4V Files?
Replies: 17
Views: 7193

To answer his question and basing this on discussion in another thread. It will automatically place chapter marks in the same place as the DVD. The work being done (which I think is awsome) seems to read the information on the DVD that contains the markers and then put them into the outputted HB fi...
by Cyander
Tue Mar 27, 2007 3:42 am
Forum: Feature Requests
Topic: Chapters inside MP4 file
Replies: 93
Views: 49662

It isn't going to be as easy as I hoped to restore the sync. The problem is that the data is frame accurate /until/ it goes through the sync step. After that, the chapter breaks lose sync, because we have no good way to keep track of how the breaks are being adjusted. I am looking into a couple ways...
by Cyander
Tue Mar 27, 2007 3:36 am
Forum: Devices and Presets
Topic: Can Chapters Be Added to M4V Files?
Replies: 17
Views: 7193

works great in our current svn. Will also be in our upcoming new release :) Well, it works, if you don't mind your chapter markers being about 1/3rd of a second off due to sync problems. I am looking at ways that chapter information can be correctly propogated using the FIFO queues to make it frame...
by Cyander
Mon Mar 26, 2007 7:33 pm
Forum: Feature Requests
Topic: Chapters inside MP4 file
Replies: 93
Views: 49662

I believe you are pretty much spot on... I extracted a text track, and re-added it to match the video's duration, and it went into sync. I am hunting around the code trying to figure out how the ripped duration gets calculated so I can get the right adjustments.
by Cyander
Mon Mar 26, 2007 7:31 pm
Forum: Devices and Presets
Topic: Apple TV tags
Replies: 23
Views: 12224

Description can't be a one-line tag. In an iTMS movie, it looks something like this: I am a movie. Watch me. ACTORS Some Yung Guy Other Yung Guy DIRECTOR Old Dude PRODUCER Other Old Dude You placed them all on one line, which breaks the parsing. If you have a movie purchased from the iTMS, then you ...
by Cyander
Mon Mar 26, 2007 3:43 pm
Forum: Devices and Presets
Topic: Apple TV tags
Replies: 23
Views: 12224

Things like Actors, Director, and Producer(s) aren't pulled from individual tags. They are pulled from the 'Description' tag which contains the movie description, using things like 'ACTORS' in the tag to tell it to start reading actors for example.
by Cyander
Fri Mar 23, 2007 8:47 pm
Forum: Feature Requests
Topic: Chapters inside MP4 file
Replies: 93
Views: 49662

I haven't really gone the whole hog with adding text tracks to libmp4v2 - that is, I don't actually use the "add text track" function I added, just the "add chapter text track" function. But it should work for basic text tracks, I think. Adding text track samples is then as easy...
by Cyander
Fri Mar 23, 2007 8:04 pm
Forum: Feature Requests
Topic: Chapters inside MP4 file
Replies: 93
Views: 49662

Text subtitles are best left for another tool, methinks. Character recognition is a nightmare, to say the least. Although a big thanks for the work to libmp4v2, as I do have a couple ideas on a Metadata tool for MP4 files where letting someone add chapter tracks and subtitles after the fact (in addi...
by Cyander
Fri Mar 23, 2007 7:48 pm
Forum: Feature Requests
Topic: Chapters inside MP4 file
Replies: 93
Views: 49662

/cry

Oh well, I still have subtitle work to do anyways. :)