HandBrake

It's non-trivial to add in an extra video encoder, unless we decide to add in a generic ffmpeg encoder which can choose any of the ffmpeg encoders. However I think that is pretty unlikely - but is the easiest way to get what you want.

Have you looked at using ffmpeg directly?

Was there a sync issue between the audio/video or the captions and the audio/video? It is possible that I've stuffed up the timestamps - I haven't actually watched a movie from start to finish with captions, I don't have many NTSC titles and didn't really feel like rewatching any of them. I did fast...

Looks good to me - that str_sep of yours does make it more maintainable, and I like how the CLI syntax is more natural now as well.

I think some others will want to take a look at this as well, since the code you are replacing is quite new itself.

Cheers, Ed.

Actually I do see a lot of value in this patch.

If you don't mind I'll continue working on it?

Cheers, Ed.

All done - markup and capitals in SVN now.

we will add the capitisation options - all in time...

When executing commands from the Terminal its within a program called the shell. The shell searches well known locations for the location of the program that you have entered. Or you can explicitly give the location. In your case you have said run the program HandBrakeCLI from your current directory...

Thanks John & Mike - I just committed D + John's comments + a fix for encoding chapters not at start - svn 2602

Try removing the level - it may be limiting you too much.

Note that with my older mac pro I have to use smcfancontrol to increase the fan speed to keep the memory cool - else when encoding with hb I'd get ECC errors as the system over heated.

So even when you get your memory replaced - I'd reccomend keeping it cool when using hb.

Cheers Ed

Thanks for bringing that to our attention - John has just committed the fix.

Thanks KonaBlend - much appreciated.

Minor change to that diff - so that the SRT defaults for offset, language and codeset get reset per SRT file. http://pastebin.ca/1469355 Index: test/test.c =================================================================== --- test/test.c (revision 2594) +++ test/test.c (working copy) @@ -72,6 +72,...

Hi, Here is the initial implementation of SubRip subtitle input, CLI only for now, and this first diff is macosx CLI without xcode only. I need help from KonaBlend to get this working for other platform/OS combinations which need the iconv library. The file reader is implemented as a work object - w...

Oops - looks like I had some CC stuff that was a work in progress in that diff. I'll remove that for now - it is the start of not including tags for MP4 CC's until we add in the tag support to the MP4 muxer. Assume that code is not there.

Hi, I ripped out native_language support from libhb and made it UI only. I also added a new CLI option --native-dub to specify that rather than the default of adding subtitles when the audio is not in your language, dub in your language instead. If you can't dub - it will fall back to subtitles. htt...

No knobs for CC in the next release - but am not against them. Just don't want to side track the UI folks at the moment.

Although - you never know maybe we will

Cheers Ed

that sounds like a good approach. Cheers Ed

Hi Van, That patch is working for me, thanks! Also thanks for the knowledge dump on what is happening. Could the reason for the PMT changes be the addition/removal of streams, since not all shows have the same streams available. And I guess maybe when they add/remove these streams they are inadverte...

But we don't want to start using this in our SVN until the LATM stuff is sorted (Well I don't anyway :) Looking at the ffmpeg-devel alias Paul Kendall is very close to having LATM support committed to ffmpeg (undergoing review) - so maybe we could ditch our LATM patch for now since it is probably mo...

The design looks sound. Splitting off of the subtitle config. Let's run with this and see how we go. The interactions between autoselected subs and manually selected is still a bit blurry to me. Especially when you have asked for some manually selected, and yet still want to search for forced subs. ...

Hi Van, Thanks for looking into this as always :) I don't understand why the change in PMT isn't announced and so HB can track the change in PIDs? Maybe by tracking what it wants to record in the PMT by type rather than PID would be handy, that way when the PMT changes we can switch to the new PIDs?...

Thanks john. We'll leave the markup then with a view to add it for mp4.

Cheers Ed

It's in ponies all discussion and input welcome here. It's a new feature - so we are interested in feedback. I want to be careful to not have too many knobs - which confuse people. And instead have sensible defaults. At the moment I'm tending towards turning off the auto-capitilisation, but leaving ...

mp4 does do markup - we haven't implemented it yet.