Search found 798 matches

by eddyg
Fri Oct 17, 2014 9:21 am
Forum: General Questions
Topic: Subtitles
Replies: 6
Views: 1009

Re: Subtitles

Brifly33 wrote:I'm trying to find out some information about doing subtitles. Is there a way to encode a dvd with the subtitles where I can decide when I'm watching the movie if I want to have to subtitles on or off?
https://trac.handbrake.fr/wiki/Subtitles
by eddyg
Wed Nov 02, 2011 12:28 pm
Forum: Development
Topic: [PATCH] [libhb] Handle bad blocks with dvdread
Replies: 7
Views: 2102

Re: [PATCH] [libhb] Handle bad blocks with dvdread

Golly gosh, I did commit it. 11 Months ago, which is many hundreds of beers ago, may explain it. The bad thing is that it didn't fix your problem. The retry is not a simple retry, after one retry it moves forward trying to sync up with the disk again. No tuning knob was provided, since it worked on ...
by eddyg
Wed Nov 02, 2011 10:20 am
Forum: Development
Topic: [PATCH] [libhb] Handle bad blocks with dvdread
Replies: 7
Views: 2102

Re: [PATCH] [libhb] Handle bad blocks with dvdread

I don't think I committed it, too close to the last release. And then forgot about it since it was in my builds anyway. You could try it on your troublesome disc and if it works I coul look at committing it. I wouldn't want to commit it now without retesting against a bad disk, and I don't recall wh...
by eddyg
Tue Aug 02, 2011 12:26 pm
Forum: Feature Requests
Topic: Applescript for EYETV to H.264
Replies: 3
Views: 706

Re: Applescript for EYETV to H.264

I did this a long time ago, haven't used it for a while. Take a look at http://www.myreflection.org/Reflection/ ... eyetv.html
by eddyg
Sun Feb 27, 2011 10:30 pm
Forum: Feature Requests
Topic: Suggestions For CC Handling
Replies: 42
Views: 6230

Re: Suggestions For CC Handling

AFAIK subtitles don't allow positioning. However you do have rows, so in theory you could map the position to which row of the three (two?) available to display it on. As far as the internals of HB are concerned if we did this I'd embed the smarts for the positioning within the 608 decoder so that i...
by eddyg
Sat Dec 04, 2010 12:55 am
Forum: Feature Requests
Topic: [Rejected] Video passthrough support
Replies: 21
Views: 4210

Re: [Rejected] Video passthrough support

I've often wanted this feature in HB, and am capable of doing it. However as noted it is non trivial, and required too much effort vs reward, so I gave up. It was mainly the pain of synchronization that causes the difficulty, and then all the special caressing as burnt in subs that would need to be ...
by eddyg
Sun Nov 28, 2010 7:51 am
Forum: Development
Topic: [PATCH] [libhb] Handle bad blocks with dvdread
Replies: 7
Views: 2102

[PATCH] [libhb] Handle bad blocks with dvdread

Hi, I encountered a DVD that had a load of bad blocks near the start of the first chapter. Handbrake using dvdnav or dvdread fails to handle this gracefully and skips to the start of the next cell as a recovery, which skipped the majority of the first chapter in my case. In this patch I have change ...
by eddyg
Sun Oct 31, 2010 4:52 am
Forum: Development
Topic: [Committed] [Core] Simultaneous subtitle support
Replies: 14
Views: 4949

Re: [Patch] [Core] Simultaneous subtitle support

Sorry about the two second thing. Maybe I'm just too slow at reading!

Although indochene was a worst case. I don't know what they were thinking hen having a couple of sentences up for less than two seconds.

Well done on all your work on subtitle support, you're doing a great job.

Cheers Ed.
by eddyg
Sat Sep 11, 2010 10:04 pm
Forum: Development
Topic: reformat the test.c file
Replies: 2
Views: 859

Re: reformat the test.c file

I prefer it how it was.

I'm against wholesale changes in formatting unless there is some benefit. We've been here before and jbrjake helped me to see the light.

Cheers Ed.
by eddyg
Sun Jun 20, 2010 7:04 am
Forum: Development
Topic: Leaking memory on subtitle scan?
Replies: 1
Views: 532

Leaking memory on subtitle scan?

Hi, I believe that some of the recent subtitle changes haven't taken into account the subtitle scan, and how it tosses the subtitle buffers after counting them. I saw this on a recent encode using the head. [16:58:12] Allocated 47287296 bytes of buffers on this pass and Freed 3243008 bytes, 44044288...
by eddyg
Wed Jun 09, 2010 4:22 am
Forum: Development
Topic: [Committed] BD PGS Subtitles
Replies: 28
Views: 8135

Re: BD PGS Subtitles

hehe. I wrote a significant amount of the existing subtitle code, so I know where all the skeletons lie. I did add the sequence number to the PG sub buffers, but it is only used in sync to decide when it is time to forward a subtitle on to the renderer. I believe this is old crufty code that isn't ...
by eddyg
Tue May 25, 2010 8:49 pm
Forum: Development
Topic: [PATCH] Basic SSA subtitle support
Replies: 12
Views: 2851

Re: [PATCH] Basic SSA subtitle support

Hi David,

any substitle rendered in HB should not be input type specific. Instead it should render the plain utf text subs in the hb subtitle packets. If the markup becomes an issue we'll have to specify what the expected format is in a hb sub.

Cheers Ed.
by eddyg
Tue May 25, 2010 8:43 pm
Forum: Development
Topic: [PATCH] Universal VOB subtitle input
Replies: 60
Views: 8716

Re: [PATCH] Universal VOB subtitle input

TedJ wrote:
Rodeo wrote:Let's not forget David ;-)
Geez, aside from writing most of the code, what did David actually do? :lol:
precisely!

(thanks David :)
by eddyg
Tue May 25, 2010 5:13 am
Forum: Development
Topic: [PATCH] Universal VOB subtitle input
Replies: 60
Views: 8716

Re: [PATCH] Universal VOB subtitle input

John & Rodeo,

Thanks again for making/doing this work.

Cheers, Ed.
by eddyg
Tue May 25, 2010 1:58 am
Forum: Development
Topic: [DOC] HandBrake Architectural Guide
Replies: 10
Views: 2173

Re: [DOC] HandBrake Architectural Guide

Good stuff, thanks for that. As for libsamplerate - it's used (no big surprise here) for changing the sample rate of the audio :) This is when the input sample rate (in khz) is different to what you need it in the output, I use it to upsample flash video audio for kids snippets from 22Khz up to 48Kh...
by eddyg
Fri May 21, 2010 1:51 pm
Forum: Windows
Topic: Avatar Subtitles
Replies: 2
Views: 1063

Re: Avatar Subtitles

Google for the subtitle files, make sure that you specify that you only want the Navi spoken parts. Then add during encoding using HB, or later using Subler (if on a Mac). When using SRTs always test encode a chapter containing the subs in question to ensure that you have the timing right, adjust as...
by eddyg
Fri May 21, 2010 1:45 pm
Forum: Bugs
Topic: Problem with --srt-file parameter - Comma in SRT filename
Replies: 1
Views: 730

Re: Problem with --srt-file parameter - Comma in SRT filenam

Hi, Interesting, and totally expected. The problem stems from the fact that HB uses the comma as a delimiter, in this case for multiple SRT filenames. From the help: --srt-file <string> SubRip SRT filename(s), separated by commas. The easiest solution is for you to rename the filenames. However if i...
by eddyg
Thu May 20, 2010 8:34 am
Forum: Development
Topic: [PATCH] Universal VOB subtitle input
Replies: 60
Views: 8716

Re: [PATCH] Universal VOB subtitle input

I'm ok with this going in. Do you have commit permission?
by eddyg
Thu May 20, 2010 3:33 am
Forum: Development
Topic: [PATCH] Universal VOB subtitle input
Replies: 60
Views: 8716

Re: [PATCH] Universal VOB subtitle input

Hi David, Looks pretty good to me. 1) Should: hb_log( "decvobsub: input color palette is empty; not demuxed properly?" ); be an error? hb_error( "decvobsub: input color palette is empty; not demuxed properly?" );? I agree that it needn't be fatal though. 2) And as for rgb2yuv() I'm surprised (as you...
by eddyg
Wed May 19, 2010 11:52 pm
Forum: Development
Topic: [PATCH] Print more subtitle info to the Activity Log
Replies: 10
Views: 1190

Re: [PATCH] Print more subtitle info to the Activity Log

Looks good to me, thanks Rodeo
by eddyg
Sat May 15, 2010 11:27 pm
Forum: Development
Topic: Combing Detection
Replies: 141
Views: 27994

Re: Combing Detection

Impressive Jon. Congrats.
by eddyg
Sat May 15, 2010 12:13 pm
Forum: Development
Topic: [PATCH] Print more subtitle info to the Activity Log
Replies: 10
Views: 1190

Re: [PATCH] Print more subtitle info to the Activity Log

Well that was pretty silly of me not to add a source type for SRT.

Oops, thought I did.

Cheers Ed.
by eddyg
Sat May 15, 2010 6:56 am
Forum: Development
Topic: [PATCH] Print more subtitle info to the Activity Log
Replies: 10
Views: 1190

Re: [PATCH] Print more subtitle info to the Activity Log

Hi Rodeo, that looks good. Only comment would be to add a check for source being SRT rather than being the final case, and having a final case being "unknown". That code is starting to get to the point where if/thens would be more appropriate, but I'm not saying that you should do that, just an asid...
by eddyg
Wed May 12, 2010 2:48 am
Forum: Development
Topic: [PATCH] Universal VOB subtitle input
Replies: 60
Views: 8716

Re: [PATCH] Universal VOB subtitle input

davidfstr wrote: Of course this problem still remains with VOB subtitle tracks coming from all other input sources (including DVDs), so maybe I should just fix the underlying problem. Probably by moving 'title->palette' to 'subtitle->palette'. Comments?
I'm good with that.

Cheers, Ed.
by eddyg
Tue Feb 09, 2010 10:05 am
Forum: Development
Topic: [PATCH] Include all audio and subtitle tracks
Replies: 3
Views: 915

Re: [PATCH] Include all audio and subtitle tracks

Sounds like a good feature to me.

Haven't looked at the code as yet, still waiting for my computer to be shipped to new house.

Cheers Ed.