[Patch] Wrong decomb defaults displayed in source and help

Developer discussion and patch submissions only!
Forum rules
This forum is for developer discussion and patch submission only.

Forum Rules can be found here

[Patch] Wrong decomb defaults displayed in source and help

Postby Rodeo » Thu Nov 05, 2009 10:53 pm

The decomb defaults were recently updated with EEDI2's defaults and the new parity parameter: http://trac.handbrake.fr/changeset/2904

But there's an issue: according to the 2-letter descriptors (i.e. MO:ME:MT:ST:BT:BX:BY:FD:MG:VA:LA:DI:ER:NO:MD:PP), decomb now takes 16 parameters, but the displayed defaults only contain 15 parameters. This two-line patch should make sure the right defaults are displayed in decomb source and CLI help:

Code: Select all
Index: test/test.c
===================================================================
--- test/test.c   (revision 2914)
+++ test/test.c   (working copy)
@@ -2307,7 +2307,7 @@
      "          <fast/slow/slower>\n"
      "    -5, --decomb            Selectively deinterlaces when it detects combing\n"
      "          <MO:ME:MT:ST:BT:BX:BY:FD:MG:VA:LA:DI:ER:NO:MD:PP>\n"
-     "          (default: 7:2:6:9:80:16:16:10:20:20:4:2:50:24:-1)\n"
+     "          (default: 7:2:6:9:80:16:16:10:20:20:4:2:50:24:1:-1)\n"
      "    -9, --detelecine        Detelecine (ivtc) video with pullup filter\n"
      "                            Note: this filter drops duplicate frames to\n"
      "                            restore the pre-telecine framerate, unless you\n"
Index: libhb/decomb.c
===================================================================
--- libhb/decomb.c   (revision 2914)
+++ libhb/decomb.c   (working copy)
@@ -22,7 +22,7 @@
     Parity
     
Defaults:
-    7:2:6:9:80:16:16:10:20:20:4:2:50:24:-1
+    7:2:6:9:80:16:16:10:20:20:4:2:50:24:1:-1
*****/

#define MODE_YADIF       1 // Use yadif

Rodeo
 
Posts: 1950
Joined: Tue Mar 03, 2009 9:55 pm

 

Re: [Patch] Wrong decomb defaults displayed in source and help

Postby Rodeo » Sun Nov 15, 2009 10:06 pm

Rodeo
 
Posts: 1950
Joined: Tue Mar 03, 2009 9:55 pm


Return to Development